Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept an object of typeDefs and resolvers #1753

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Don't accept an object of typeDefs and resolvers #1753

merged 6 commits into from
Sep 20, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Sep 19, 2022

  • Remove getDefaultSchema
  • No longer set a default schema
  • No longer accept { typeDefs, resolvers } but use createSchema({ typeDefs, resolvers }) instead

So Yoga won't have @graphql-tools/schema in the bundle if schema is created in a different way.

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: 8640202

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
graphql-yoga Major
@graphql-yoga/common Patch
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-response-cache Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 196036      ✗ 0    
     data_received..................: 29 MB   974 kB/s
     data_sent......................: 11 MB   376 kB/s
     http_req_blocked...............: avg=1.08µs   min=700ns   med=1µs     max=253.19µs p(90)=1.3µs    p(95)=1.6µs   
     http_req_connecting............: avg=1ns      min=0s      med=0s      max=103.3µs  p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=237.65µs min=166.8µs med=216.9µs max=18.03ms  p(90)=252.3µs  p(95)=290.71µs
       { expected_response:true }...: avg=237.65µs min=166.8µs med=216.9µs max=18.03ms  p(90)=252.3µs  p(95)=290.71µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 98018
     http_req_receiving.............: avg=17.83µs  min=10.2µs  med=16.4µs  max=5.41ms   p(90)=20.8µs   p(95)=23.1µs  
     http_req_sending...............: avg=5.7µs    min=3.8µs   med=4.7µs   max=4.32ms   p(90)=6.3µs    p(95)=8.6µs   
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=214.11µs min=148.9µs med=195.5µs max=17.89ms  p(90)=225.6µs  p(95)=258.69µs
     http_reqs......................: 98018   3267.082461/s
     iteration_duration.............: avg=301.6µs  min=217µs   med=279µs   max=18.52ms  p(90)=325.79µs p(95)=371.59µs
     iterations.....................: 98018   3267.082461/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://25ff37d5.graphql-yoga.pages.dev

@ardatan ardatan force-pushed the remove-tools branch 2 times, most recently from 48c226b to 396006d Compare September 19, 2022 18:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 2.4.3-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20220920120700-db0822b7 npm ↗︎ unpkg ↗︎

README.md Outdated Show resolved Hide resolved
@ardatan ardatan merged commit eeaced0 into v3 Sep 20, 2022
@ardatan ardatan deleted the remove-tools branch September 20, 2022 15:59
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants