Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create URL instance once and pass it in context for onRequestHook #1684

Merged

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Aug 30, 2022

closes #1486

@saihaj saihaj requested review from n1ru4l and ardatan August 30, 2022 15:43
@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

⚠️ No Changeset found

Latest commit: 0cd839d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 166764      ✗ 0    
     data_received..................: 22 MB   739 kB/s
     data_sent......................: 9.6 MB  320 kB/s
     http_req_blocked...............: avg=1.26µs   min=800ns   med=1µs     max=342.6µs p(90)=1.6µs   p(95)=1.9µs  
     http_req_connecting............: avg=2ns      min=0s      med=0s      max=177.9µs p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=277.87µs min=180.2µs med=248.7µs max=20.42ms p(90)=310.1µs p(95)=349.7µs
       { expected_response:true }...: avg=277.87µs min=180.2µs med=248.7µs max=20.42ms p(90)=310.1µs p(95)=349.7µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 83382
     http_req_receiving.............: avg=21.07µs  min=10.8µs  med=18.8µs  max=11.12ms p(90)=25.7µs  p(95)=28.1µs 
     http_req_sending...............: avg=8.53µs   min=4.1µs   med=6.5µs   max=3.64ms  p(90)=11.4µs  p(95)=12.5µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=248.27µs min=161.1µs med=221.4µs max=20.3ms  p(90)=276.3µs p(95)=314.3µs
     http_reqs......................: 83382   2779.251117/s
     iteration_duration.............: avg=352.86µs min=235.1µs med=320.8µs max=21ms    p(90)=396.6µs p(95)=442.8µs
     iterations.....................: 83382   2779.251117/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@saihaj saihaj merged commit de007cb into v3 Aug 30, 2022
@saihaj saihaj deleted the saihaj/1486-create-url-instance-once-and-pass-it-through-onrequest branch August 30, 2022 16:06
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants