Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apq branding #1479

Merged
merged 8 commits into from
Jul 27, 2022
Merged

feat: apq branding #1479

merged 8 commits into from
Jul 27, 2022

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Jul 27, 2022

Instead of making an all-purpose store it makes more sense to have automatic persisted queries as a standalone plugin and persisted documents as a separate plugin.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

⚠️ No Changeset found

Latest commit: 1f77e83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@n1ru4l n1ru4l changed the base branch from master to v3 July 27, 2022 14:42
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 215916      ✗ 0     
     data_received..................: 29 MB   957 kB/s
     data_sent......................: 12 MB   414 kB/s
     http_req_blocked...............: avg=1.16µs   min=700ns    med=1µs      max=747.39µs p(90)=1.5µs    p(95)=1.7µs   
     http_req_connecting............: avg=5ns      min=0s       med=0s       max=588.99µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=208.15µs min=139.1µs  med=186.69µs max=17.18ms  p(90)=238.49µs p(95)=264.29µs
       { expected_response:true }...: avg=208.15µs min=139.1µs  med=186.69µs max=17.18ms  p(90)=238.49µs p(95)=264.29µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 107958
     http_req_receiving.............: avg=17.85µs  min=10.1µs   med=16.4µs   max=11.07ms  p(90)=21.3µs   p(95)=25.29µs 
     http_req_sending...............: avg=5.88µs   min=3.9µs    med=4.7µs    max=1.3ms    p(90)=7µs      p(95)=10.2µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=184.41µs min=118.09µs med=165.29µs max=16.82ms  p(90)=209.89µs p(95)=233.79µs
     http_reqs......................: 107958  3598.437739/s
     iteration_duration.............: avg=273.14µs min=190.39µs med=248.39µs max=17.53ms  p(90)=312.09µs p(95)=342.89µs
     iterations.....................: 107958  3598.437739/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Jul 27, 2022

@ardatan APQ and Persisted Operations serve two different purposes.

The idea behind APQ is to reduce upstream traffic from client to server.

The idea behind Persisted Operations is security by preventing the execution of arbitrary operations.


From a marketing and feature perspective, it makes sense to divide these two use-cases into two different plugins in order to make each of those usable with minimal setup for those use-cases.

@ardatan ardatan merged commit 331e812 into v3 Jul 27, 2022
@ardatan ardatan deleted the feat-apq-branding branch July 27, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants