Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: landing page #1478

Merged
merged 4 commits into from
Jul 28, 2022
Merged

feat: landing page #1478

merged 4 commits into from
Jul 28, 2022

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Jul 27, 2022

The landing page is shown on a 404.
The landing page can be disabled by passing landingPage: false to createYoga.

image
image


Closes #1353

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

⚠️ No Changeset found

Latest commit: 41439c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@n1ru4l n1ru4l changed the title Feat landing page feat: landing page Jul 27, 2022
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@n1ru4l n1ru4l changed the base branch from master to v3 July 27, 2022 14:43
@n1ru4l n1ru4l marked this pull request as ready for review July 28, 2022 07:38
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 139314      ✗ 0    
     data_received..................: 19 MB   618 kB/s
     data_sent......................: 8.0 MB  267 kB/s
     http_req_blocked...............: avg=1.55µs   min=1µs      med=1.3µs    max=926.85µs p(90)=1.9µs    p(95)=2.4µs   
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=122µs    p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=333.71µs min=190.01µs med=276.41µs max=22.32ms  p(90)=384.22µs p(95)=485.44µs
       { expected_response:true }...: avg=333.71µs min=190.01µs med=276.41µs max=22.32ms  p(90)=384.22µs p(95)=485.44µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 69657
     http_req_receiving.............: avg=25.58µs  min=13.2µs   med=21.8µs   max=6.25ms   p(90)=30.9µs   p(95)=36µs    
     http_req_sending...............: avg=10.84µs  min=4.6µs    med=8.3µs    max=2.74ms   p(90)=13.6µs   p(95)=14.7µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=297.28µs min=167.9µs  med=244.21µs max=22.17ms  p(90)=342.91µs p(95)=432.44µs
     http_reqs......................: 69657   2321.793176/s
     iteration_duration.............: avg=424.55µs min=250.81µs med=360.82µs max=22.94ms  p(90)=491.42µs p(95)=608.83µs
     iterations.....................: 69657   2321.793176/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@n1ru4l n1ru4l merged commit f325429 into v3 Jul 28, 2022
@n1ru4l n1ru4l deleted the feat-landing-page branch July 28, 2022 09:57
@theguild-bot theguild-bot mentioned this pull request Aug 9, 2022
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants