-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urql Exchange & Apollo Client Link #1448
Conversation
🦋 Changeset detectedLatest commit: 6cdc552 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared
|
✅ Benchmark Results
|
async *subscribe() { | ||
while (true) { | ||
await new Promise((resolve) => setTimeout(resolve, 1000)) | ||
yield new Date().toISOString() | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need to use setTimeout here, can we change the test to not take "real" time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, also I think we could also set the target branch of this to v3 and make it part of the big release? If so the documentation changes must be reverted and re-applied to our new v3 documentation.
Ok done @n1ru4l ! |
Closes #1381
Closes #1380