Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urql Exchange & Apollo Client Link #1448

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Urql Exchange & Apollo Client Link #1448

merged 1 commit into from
Jul 26, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jul 23, 2022

Closes #1381
Closes #1380

@ardatan ardatan requested a review from n1ru4l July 23, 2022 15:37
@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2022

🦋 Changeset detected

Latest commit: 6cdc552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-yoga/urql-exchange Major
@graphql-yoga/apollo-link Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@graphql-yoga/apollo-link@1.0.0-canary-d4993bf.0
@graphql-yoga/common@3.0.0-canary-d4993bf.0
graphql-yoga@3.0.0-canary-d4993bf.0
@graphql-yoga/node@3.0.0-canary-d4993bf.0
@graphql-yoga/render-graphiql@3.0.0-canary-d4993bf.0
@graphql-yoga/urql-exchange@1.0.0-canary-d4993bf.0

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 111624      ✗ 0    
     data_received..................: 15 MB   495 kB/s
     data_sent......................: 6.4 MB  214 kB/s
     http_req_blocked...............: avg=2.08µs   min=1.3µs    med=1.9µs    max=540.02µs p(90)=2.29µs   p(95)=2.6µs   
     http_req_connecting............: avg=2ns      min=0s       med=0s       max=142.9µs  p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=414.49µs min=259.4µs  med=353.91µs max=23.43ms  p(90)=476.11µs p(95)=622.56µs
       { expected_response:true }...: avg=414.49µs min=259.4µs  med=353.91µs max=23.43ms  p(90)=476.11µs p(95)=622.56µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 55812
     http_req_receiving.............: avg=31.38µs  min=17.89µs  med=26.6µs   max=9.91ms   p(90)=36.1µs   p(95)=42.4µs  
     http_req_sending...............: avg=13.78µs  min=6.7µs    med=9.4µs    max=3.22ms   p(90)=19.2µs   p(95)=20.1µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=369.32µs min=228.3µs  med=310.31µs max=23.28ms  p(90)=426.31µs p(95)=556.46µs
     http_reqs......................: 55812   1860.298721/s
     iteration_duration.............: avg=529.81µs min=335.31µs med=466.01µs max=24.19ms  p(90)=606.92µs p(95)=778.96µs
     iterations.....................: 55812   1860.298721/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@ardatan ardatan requested a review from saihaj July 25, 2022 12:28
Comment on lines +40 to +44
async *subscribe() {
while (true) {
await new Promise((resolve) => setTimeout(resolve, 1000))
yield new Date().toISOString()
}
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need to use setTimeout here, can we change the test to not take "real" time?

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, also I think we could also set the target branch of this to v3 and make it part of the big release? If so the documentation changes must be reverted and re-applied to our new v3 documentation.

@ardatan
Copy link
Collaborator Author

ardatan commented Jul 26, 2022

Ok done @n1ru4l !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Urql exchange package Apollo Client Link package
3 participants