Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single package for all #1375

Closed
wants to merge 4 commits into from
Closed

Single package for all #1375

wants to merge 4 commits into from

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jul 8, 2022

  • See the changeset for API changes
  • I also did small refactor in some parts which doesn't have any effects in functionality.
  • Removed the extra examples for aws-lambda-bundle and vercel-function then pointed the pulumi script to use the existing aws-lambda and nextjs example projects in E2E tests

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

🦋 Changeset detected

Latest commit: fbe02c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
graphql-yoga Major
@graphql-yoga/common Major
@graphql-yoga/node Major
@graphql-yoga/render-graphiql Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
defer-stream-example Patch
error-masking-example Patch
express-example Patch
fastify-modules-example Patch
fastify-example Patch
file-upload-nextjs-pothos Patch
file-upload-nexus Patch
file-upload Patch
example-generic-auth Patch
graphql-config-example Patch
graphql-ws Patch
hackernews Patch
hello-world Patch
issue-template Patch
koa-example Patch
example-live-query Patch
nextjs-auth Patch
nextjs Patch
node-esm Patch
example-redis-pub-sub Patch
service-worker Patch
subscriptions-example Patch
sveltekit Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 218814      ✗ 0     
     data_received..................: 29 MB   970 kB/s
     data_sent......................: 13 MB   419 kB/s
     http_req_blocked...............: avg=1.16µs   min=700ns   med=1µs     max=3.69ms  p(90)=1.4µs   p(95)=1.7µs  
     http_req_connecting............: avg=1ns      min=0s      med=0s      max=119.7µs p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=205.48µs min=138.8µs med=185.7µs max=19.2ms  p(90)=233.3µs p(95)=270.9µs
       { expected_response:true }...: avg=205.48µs min=138.8µs med=185.7µs max=19.2ms  p(90)=233.3µs p(95)=270.9µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 109407
     http_req_receiving.............: avg=17.55µs  min=10.3µs  med=16.29µs max=6.14ms  p(90)=21.5µs  p(95)=25.1µs 
     http_req_sending...............: avg=5.95µs   min=3.9µs   med=4.7µs   max=2.05ms  p(90)=6.7µs   p(95)=10.1µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=181.98µs min=113.6µs med=164.5µs max=19.1ms  p(90)=204.9µs p(95)=239.1µs
     http_reqs......................: 109407  3646.756631/s
     iteration_duration.............: avg=269.62µs min=192.1µs med=246.3µs max=19.66ms p(90)=308.5µs p(95)=350.6µs
     iterations.....................: 109407  3646.756631/s
     vus............................: 0       min=0         max=1   
     vus_max........................: 1       min=1         max=1   

@theguild-bot theguild-bot mentioned this pull request Jul 14, 2022
@n1ru4l
Copy link
Collaborator

n1ru4l commented Jul 18, 2022

@ardatan can you please rebase this and change the target branch to v3?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@graphql-yoga/common@3.0.0-canary-1a621d7.0
graphql-yoga@3.0.0-canary-1a621d7.0
@graphql-yoga/node@3.0.0-canary-1a621d7.0
@graphql-yoga/render-graphiql@3.0.0-canary-1a621d7.0

* chore: remove node 12 checks in ci/cd, changed target to es2020

* Add changeset

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
renovate bot and others added 2 commits July 24, 2022 08:39
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update actions/checkout action to v3 (#1431)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency ioredis to v5.2.2 (#1450)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Replace cross-undici-fetch with @whatwg-node/fetch

* chore(deps): update dependency vite to v3

* Fix GraphiQL build

* Go

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
@ardatan ardatan added this to the v3 milestone Jul 24, 2022
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation changes should be reverted - If we just update the v2 docs to v3, there won't be any v2 docs anymore.

Instead we should start a new v3 documentation on a new route (e.g. graphql-yoga.com/docs/v3/... - or probably even better - move the version 2 docs to /v2/....

Also the branch needs to be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants