-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RedisEventTarget #1299
feat: RedisEventTarget #1299
Conversation
943bee0
to
3a27d35
Compare
3a27d35
to
8ad6960
Compare
🦋 Changeset detectedLatest commit: 9fff3b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8ad6960
to
76ee61d
Compare
76ee61d
to
13c0a7a
Compare
✅ Benchmark Results
|
The latest changes of this PR are available as canary in npm (based on the declared
|
@@ -3,7 +3,7 @@ import puppeteer from 'puppeteer'; | |||
let browser: puppeteer.Browser; | |||
let page: puppeteer.Page; | |||
|
|||
describe('SvelteKit integration', () => { | |||
describe.skip('SvelteKit integration', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping because it is also broken on master. See #1378
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotansimha @n1ru4l the SvelteKit integration has been broken in the following PR that introduced breaking changes in yoga/common: #1364
TypedEventTarget
type into a standalon package@graphql-yoga/typed-event-target
.@graphql-yoga/redis-event-target
package which has a EventTarget implementation based on redis pub/sub usingioredis
Future thoughts:
data
attribute, and now I figured out that there is alsoCustomEvent
, but it is still not available in the latest Node.js. Changing the API to useCustomEvent
would be a breaking change, thus for now I kept re-using theEvent
. In the next major release, we can consider usingCustomEvent
instead.Node.js Progress for supporting
CustomEvent
:CustomEvent
nodejs/node#43514Closes #1297