Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Sveltekit on master #1378

Closed
Tracked by #1358
n1ru4l opened this issue Jul 12, 2022 · 1 comment
Closed
Tracked by #1358

Broken Sveltekit on master #1378

n1ru4l opened this issue Jul 12, 2022 · 1 comment

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jul 12, 2022

Describe the bug

The SvelteKit build and tests on master are failing.

Your Example Website or App

https://github.com/dotansimha/graphql-yoga

Steps to Reproduce the Bug or Issue

Run tests on https://github.com/dotansimha/graphql-yoga

Expected behavior

Tests should pass :)

Screenshots or Videos

No response

Platform

  • GitHub Actions

Additional context

When I run yarn test locally SvelteKit tests always fail, because I have to run some manual steps. Instead the test file/suite should spawn the SvelteKit process.

The svelte command fails locally with the following command:


  SvelteKit v1.0.0-next.348

  local:   http://localhost:3007
  network: not exposed

  Use --host to expose server to other devices on this network


TypeError: handler is not a function
    at render_endpoint (file:///Users/laurinquast/Projects/graphql-yoga/examples/sveltekit/.svelte-kit/output/server/index.js:179:26)
    at resolve (file:///Users/laurinquast/Projects/graphql-yoga/examples/sveltekit/.svelte-kit/output/server/index.js:2155:59)
    at async respond (file:///Users/laurinquast/Projects/graphql-yoga/examples/sveltekit/.svelte-kit/output/server/index.js:2111:22)
    at async file:///Users/laurinquast/Projects/graphql-yoga/node_modules/@sveltejs/kit/dist/chunks/index4.js:166:5
@ardatan
Copy link
Collaborator

ardatan commented Jul 20, 2022

I think this has been fixed since the tests are passing.

@ardatan ardatan closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants