Remove stash gold sharing

[kphoenix137]

Prevents utilizing stash gold while at towner stores.

Justification:

• Players may want to utilize stash with some characters, but not others (purist playthroughs, ironman, etc.)
• Players not on Linux/PC may have difficulty moving around files to prevent some characters from utilizing stash gold
• Utilizing stash gold may feel a bit "immersion breaking", as they are summoning their wealth through the veil (I don't feel as strongly about this argument as the others)
• Players may generally just want a degree of separation between their characters
• This change places more usefulness on the Auric Amulet
• This change places more usefulness on the general stash feature of withdrawing gold, making the game feel more interactive in the sense of town interactions
• While the immediate reaction may be negative due to players generally never being in favor of being inconvenienced, the impact of quite a change is low, and players are still at a much greater convenience than when they played Diablo prior to a stash being introduced (In fact, stash mods for vanilla did not even have this feature)
• Stash gold sharing may make a better candidate for a Lua mod going forward, as this feature proves to be annoying as much as it is beneficial, and adding more special cases and toggles doesn't seem like the right step forward.

[kphoenix137]

Maybe a better solution would be introducing a personal stash page per character that gets saved to a new file in the archive, where gold for towners will only read from the individual stash

[DakkJaniels]

Some platforms cannot remove gold from stash.

[AJenbo]

Players not on Linux/PC

I tend to use the term "computer" to not exclude Mac/FreeBSD/etc :D

[AJenbo]

Maybe a better solution would be introducing a personal stash page per character that gets saved to a new file in the archive, where gold for towners will only read from the individual stash

Yeah that's the solution I have been planning for my self. I think the current implementation for this PR assumes that a few people not liking the current solution means no one does, but I think I have seen as many people appreciating it as has complained about it. Which I take as a majority generally liking it.

I have myself run in to situations where I would have preferred that the gold was in a private stash, but I see this more as something that can be improved rather then something that is broken.

Two complications that we have to figure out:

• What happens to existing stash content
• Can we provide a way to move gold in to the shared stash to transfer it

Maybe a solution could be to have both shared and private gold, and a button to push an amount between them?

[kphoenix137]

Maybe a better solution would be introducing a personal stash page per character that gets saved to a new file in the archive, where gold for towners will only read from the individual stash

Yeah that's the solution I have been planning for my self. I think the current implementation for this PR assumes that a few people not liking the current solution means no one does, but I think I have seen as many people appreciating it as has complained about it. Which I take as a majority generally liking it.

I have myself run in to situations where I would have preferred that the gold was in a private stash, but I see this more as something that can be improved rather then something that is broken.

Two complications that we have to figure out:

• What happens to existing stash content
• Can we provide a way to move gold in to the shared stash to transfer it

Maybe a solution could be to have both shared and private gold, and a button to push an amount between them?

The latter is what I had in mind. We can add 2 buttons to the stash window where one is labeled "Private" and the other "Shared". Pressing one keeps it pressed down and pops the other one up. The shared one would go on as usual with no changes; just the current stash how it is. The private one would read and write a single page within the sv/hsv archive and not display page changing buttons.

[AJenbo]

Yeah an option to switch between private/shared might make sens, then gold can be transferred though the hero's inventory just like any other item.