Add gameplay options to hide item and gold stash from the player

[hfc2x]

This is mostly to address discussion in #7462, because of certain devices that run DevilutionX (such as devices running Batocera) don't have easy access to a file manager to disable or move the stash.sv file to prevent the stash and/or gold from being shared between different saves. This has been brought up a couple of times by different users.

These new gameplay options don't disable the item stash offered by Gillian, but rather hide it from the player. Two new options are added in the Gameplay Options menu:

• Enable item storage: This option will allow the player to access Gillian's item storage. Comes enabled by default to keep it consistent with current behavior. Disabling this option will hide the storage from her dialog options. Disabling this option will also hide the gold stored in the item stash from being visible to other stores in town.
• Stashed gold is usable: This option will allow gold stored in Gillian's stash to be directly usable in stores without the need to be present in the player's storage. Comes enabled by default, to keep it consistent with current behavior. Disabling this option will only make it so stores in town require gold be withdrawn from the stash to be usable.

[Trihedraf]

The plan laid out in the closed pr you referenced is to add individual stashes and have gold only being usable for the vendors out of the individual stash not directly from shared stash anymore.

No more new toggles.

[kphoenix137]

The plan laid out in the closed pr you referenced is to add individual stashes and have gold only being usable for the vendors out of the individual stash not directly from shared stash anymore.

No more new toggles.

+1

Adding private stash per character is something that we should have anyway which some players have requested previously. Additionally, private stashes per character would allow us to solve the gold in stores thing more logically. Given that stash is a completely optional feature, a toggle is useless.

[AJenbo]

As has been pointed out by others this seems to be based on a miss understanding of what the intended solution should be.

[glebm]

DevilutionX (such as devices running Batocera) don't have easy access to a file manager to disable or move the stash.sv

In the meantime, Batocera actually comes with Commander (made by me btw) that can be used to move files https://github.com/od-contrib/commander

[kphoenix137]

If you have the time and energy, it would be a huge help if you helped with creating a per player private stash that holds separate gold storage from the shared stash. We just need to be careful not to modify how shared stash works.