[Feature Request]: Gameplay option to disable stash

[hfc2x]

Feature Type

Quality of Life

Describe

I know you can just play the entire game without selecting Gillian's storage option, but it'd be a nice feature for people that just prefer her to be a conversation NPC only, like in vanilla. Also for people who don't want to go through the trouble of having to delete the stash file every new game.

[Trihedraf]

This has been discussed before and shut down.

[AJenbo]

If you can't stop your self from using the storage, what's going to make you not just enable it?

[kphoenix137]

It's quite literally an optional and unobtrusive feature (evident by the fact we still have people asking how they can access stash). Simply making the personal decision to not use it is a lot less hassle than maintainers having to add yet another toggle/special case.

[hfc2x]

I concede that for items and weapons, it's alright to just not talk to Gillian. But the money being shared between characters is very obtrusive. Having two players using different characters that end up sharing their money (because it's visible to the shopkeepers) should not be a forced feature.

[AJenbo]

So your argument is that you sometimes want to use it for some characters, but not others?

[kphoenix137]

I do think it's a good point about the gold being used for towners. While it's convenient, I personally don't care for it, because I also like to have a degree of separation between characters, and shared gold breaks that barrier, which can be cumbersome in cases when I'm debugging (I need to rename the stash file to avoid accidentally spending legitimate gold)

[kphoenix137]

#7462

[hfc2x]

So your argument is that you sometimes one to use it for some characters, but not others

I don't know why you feel the need to respond with snark to a clarification about something a simple Google search will show that other people also consider an issue. Funnily enough, you also gave a snarky response to this person, as if moving/renaming stash.sv (in this person's case, on a device running Batocera) is not a cumbersome solution.

I do think it's a good point about the gold being used for towners. While it's convenient, I personally don't care for it, because I also like to have a degree of separation between characters, and shared gold breaks that barrier, which can be cumbersome in cases when I'm debugging (I need to rename the stash file to avoid accidentally spending legitimate gold)

#7462

Thank you for taking the time to consider this, and propose a solution.

[kphoenix137]

So your argument is that you sometimes one to use it for some characters, but not others

I don't know why you feel the need to respond with snark to a clarification about something a simple Google search will show that other people also consider an issue. Funnily enough, you also gave a snarky response to this person, as if moving/renaming stash.sv (in this person's case, on a device running Batocera) is not a cumbersome solution.

I do think it's a good point about the gold being used for towners. While it's convenient, I personally don't care for it, because I also like to have a degree of separation between characters, and shared gold breaks that barrier, which can be cumbersome in cases when I'm debugging (I need to rename the stash file to avoid accidentally spending legitimate gold)

#7462

Thank you for taking the time to consider this, and propose a solution.

I wouldn't perceive his responses as being "snarky". He is logical and matter-of-fact. His response to you was asking for clarification. Also, his native language isn't English, and he sometimes phrases things differently than a native English speaker that might be interpreted differently, especially without the nuance of vocal communication.

[AJenbo]

So your argument is that you sometimes one to use it for some characters, but not others

I don't know why you feel the need to respond with snark

I don't know why you think it's snark, I was just checking to see if I understood your argument correctly. I do have a tendency to be terse, maybe that's what you are picking up on. Additionally on GitHub I mostly use a neutral command tone as that's common when dealing with programming.

a simple Google search will show that other people #5278.

Why should I do a google search to find a conversation I remember?

as if moving/renaming stash.sv (in this person's case, on a device running Batocera) is not a cumbersome solution.

I gave them an answer they can benefit from now rather then having to wait for a solution to be programmed and released, your talking as if that is a simple thing to do.

[hfc2x]

I gave them an answer they can benefit from now rather then having to wait for a solution to be programmed and released, your talking as if that is a simple thing to do.

I see. In that case, I want to ask: would it be okay for me to make a pull request for this then? Just by glancing at the code, I think I can add an option hide the dialogue option and the gold stored in the stash from being visible to shopkeepers. I'm obviously not a maintainer, so I don't know the gameplay ramifications of doing this, so this approach could be too simplistic.

I'm talking about adding a gameplay option that wouldn't interfere with the stash code in any way, just optionally hiding it from the player, and I already have an idea of how to do it (obviously for QoL reasons, the stash should be enabled by default, like it is right now).

[AJenbo]

We are considering some other options, there's a bit more context here: #7462

Ideally options likes these should become mods that you can toggle, that's the goal of the next major version. If you can contribute towards that it would be very welcome.