-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
490 implement lime for timeseries #527
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Note that since the general explainer function for timeseries have already been implemented in PR #506 Lines 35 to 55 in d4b63b4
|
…-ai/dianna into 490-implement-lime-for-timeseries
…taset in tutorials/data
@geek-yang, Lime for time-series is working now in Dianna! Can you have a look? We can have a discussion about the format of the class maybe after you do. |
Hi @cpranav93, good job! I tested it and it works very well with the coffee dataset. Follow our discussion, I made some changes and now it supports the api interface of dianna, which also works with onnx when you wrap it up as a model runner. But when I try to test it with weather dataset, it doesn't work. I tried to make some changes to it but still didn't get any sensible result (you can find my test in the notebook |
…-ai/dianna into 490-implement-lime-for-timeseries
Finally this big PR (about 1800 lines of code added) is ready for review. Note that this is the first step towards our own implementation of LIME for timeseries data and more need to be achieved to make it better. But now it already functions in a way that we can further polish it to improve the results from the explainer (and most importantly, it is integrated with our dianna api and you can run all notebooks without an error 😜). In the code you will find many
Also, some results from the notebooks are not good enough, and they are expected to be improved when we fix issues related to the algorithm of LIME (due to the use of
Please for now just ignore these TODOs when you review this PR. |
Great work @geek-yang! It really looks great now. The new issues you created will also be very helpful in improving our implementation of lime as well! Go ahead and merge. |
In this PR, we implement LIME for timeseries based on
Lime-for-time
andLimeSegmentation
, which are described in this paper https://doi.org/10.1016/j.jocs.2021.101539.To make use of the maskers generator, this PR already includes the working progress in PR #494 (which is related to issue #477).
This PR closes issue #490.