Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time step masking (refs #477) #494

Merged
merged 14 commits into from
Mar 21, 2023
Merged

add time step masking (refs #477) #494

merged 14 commits into from
Mar 21, 2023

Conversation

cwmeijer
Copy link
Contributor

@cwmeijer cwmeijer commented Mar 1, 2023

Add basic mean masking for timeseries.
@geek-yang already reviewed most of it.

@cwmeijer
Copy link
Contributor Author

cwmeijer commented Mar 8, 2023

Linter issues reported by Github actions are in the dashboard and have already been fixed in main since this run.

@cwmeijer cwmeijer marked this pull request as ready for review March 8, 2023 10:15
@cwmeijer cwmeijer requested a review from geek-yang March 8, 2023 10:16
Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just notice some missing docstrings and a minor error a warning messages. Please address them and feel free to merge it when all checks turn green (fix isort complaint)!

dianna/utils/maskers.py Outdated Show resolved Hide resolved
dianna/utils/maskers.py Outdated Show resolved Hide resolved
dianna/utils/maskers.py Outdated Show resolved Hide resolved
dianna/utils/maskers.py Outdated Show resolved Hide resolved
dianna/utils/maskers.py Outdated Show resolved Hide resolved
dianna/utils/maskers.py Outdated Show resolved Hide resolved
cwmeijer and others added 6 commits March 21, 2023 10:41
Co-authored-by: Yang <y.liu@esciencecenter.nl>
Co-authored-by: Yang <y.liu@esciencecenter.nl>
Co-authored-by: Yang <y.liu@esciencecenter.nl>
Co-authored-by: Yang <y.liu@esciencecenter.nl>
@cwmeijer cwmeijer merged commit 9239dc3 into main Mar 21, 2023
@geek-yang geek-yang deleted the 477-time-series-maskers branch April 3, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement time series masking functionality for RISE (and LIME)
2 participants