Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to show/hide parameters #504

Merged
merged 13 commits into from
Mar 15, 2023
Merged

Add button to show/hide parameters #504

merged 13 commits into from
Mar 15, 2023

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Mar 7, 2023

This PR adds a collapsible parameters section.

One issue is that this requires an external stylesheet that changes our layout slightly.

Follows up on #502

Closes #414

@stefsmeets
Copy link
Contributor Author

Hi @laurasootes , could you have a look and let me know if this is what you had in mind?

@laurasootes
Copy link
Contributor

The collapsable parameter menu looks good! This exactly what we had in mind in terms of functionality.

However, this PR seems to have broken 3 things:

  • the submit button reaches all the way to the side, there used to be some space here
  • The select XXX is no longer light blue
  • The update explanation buttons does not work in the text tab (does work in the image tab)

image

@stefsmeets
Copy link
Contributor Author

Yeah, this is a side-effect of adding another style sheet. It clashes with all the inline styling done in the dashboard.

@laurasootes
Copy link
Contributor

hmm, annoying. I presume it is fixable? 👼

@stefsmeets
Copy link
Contributor Author

@laurasootes I fixed the problem with the update button and worked around the style issues.

I think the future plan should include having a custom css file that we control and where we can consolidate the components we need to avoid style conflicts / inline style overrides.

@laurasootes laurasootes mentioned this pull request Mar 14, 2023
@laurasootes
Copy link
Contributor

For the image tab the run fails and gives an "tuple index out of range" when trying run it using RISE (not for the other methods, also not in text tab)

@stefsmeets
Copy link
Contributor Author

For the image tab the run fails and gives an "tuple index out of range" when trying run it using RISE (not for the other methods, also not in text tab)

Can you tell me your inputs? Because I don't see this happening on my side.
Can you also test if you see it in the main branch?

@laurasootes
Copy link
Contributor

Turns out it was me, so no problems

@stefsmeets stefsmeets merged commit 0d231f0 into main Mar 15, 2023
@stefsmeets stefsmeets deleted the collapse_params branch March 15, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: create collapse menu for parameters
2 participants