-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to show/hide parameters #504
Conversation
Hi @laurasootes , could you have a look and let me know if this is what you had in mind? |
The collapsable parameter menu looks good! This exactly what we had in mind in terms of functionality. However, this PR seems to have broken 3 things:
|
Yeah, this is a side-effect of adding another style sheet. It clashes with all the inline styling done in the dashboard. |
hmm, annoying. I presume it is fixable? 👼 |
@laurasootes I fixed the problem with the update button and worked around the style issues. I think the future plan should include having a custom css file that we control and where we can consolidate the components we need to avoid style conflicts / inline style overrides. |
For the image tab the run fails and gives an "tuple index out of range" when trying run it using RISE (not for the other methods, also not in text tab) |
Can you tell me your inputs? Because I don't see this happening on my side. |
Turns out it was me, so no problems |
This PR adds a collapsible parameters section.
One issue is that this requires an external stylesheet that changes our layout slightly.
Follows up on #502
Closes #414