Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dashboard #502

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Refactor dashboard #502

merged 4 commits into from
Mar 7, 2023

Conversation

stefsmeets
Copy link
Contributor

Trying to make sense of the dashboard for #414, I refactored the different elements to make it a bit easier to work with.

@stefsmeets
Copy link
Contributor Author

Would this be useful for the project? Could you have a look @laurasootes ?

@laurasootes
Copy link
Contributor

fixes #497 (comment)

Copy link
Contributor

@laurasootes laurasootes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pulling apart these different parts already helps a lot. The images.py and text.py remain large and hard to read files, but I am not sure if/how we can make that better. I don't know if we should also try to pull apart some parts of the callbacks file

@laurasootes
Copy link
Contributor

Only thing: you made the linter unhappy :)

@stefsmeets
Copy link
Contributor Author

Thanks, the linter also makes me unhappy 😅
I will fix the issues and then merge 🚀

@stefsmeets stefsmeets merged commit 5067f81 into main Mar 7, 2023
@stefsmeets stefsmeets deleted the refactor_dashboard branch March 7, 2023 15:34
@laurasootes
Copy link
Contributor

@stefsmeets I do not want to make you unhappy again, but the linter still is 😥

@stefsmeets
Copy link
Contributor Author

This linting is madness. How do you guys work without auto-formatters that fix these automatically 😬

I can address this with #492 #493

@laurasootes
Copy link
Contributor

laurasootes commented Mar 8, 2023

Sounds like a plan. The linting is currently broken ~90% of the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants