-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dashboard #502
Refactor dashboard #502
Conversation
33a2e67
to
c564811
Compare
c564811
to
fa83276
Compare
Would this be useful for the project? Could you have a look @laurasootes ? |
fixes #497 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Pulling apart these different parts already helps a lot. The images.py and text.py remain large and hard to read files, but I am not sure if/how we can make that better. I don't know if we should also try to pull apart some parts of the callbacks file
Only thing: you made the linter unhappy :) |
Thanks, the linter also makes me unhappy 😅 |
@stefsmeets I do not want to make you unhappy again, but the linter still is 😥 |
Sounds like a plan. The linting is currently broken ~90% of the time |
Trying to make sense of the dashboard for #414, I refactored the different elements to make it a bit easier to work with.