make label a required argument (Fixes #131) #426
Conversation
|
The error checking is at least working as advertised, I see a whole bunch of TypeErrors in the tests :D |
|
Always great rushing commit out 1 minute before going home ;-) Back into draft it is. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Everything should be OK now. |
There was a problem hiding this comment.
Looks good! I don't understand why the fair-software CI is failing, it seems unrelated to this PR.
The linter is complaining about some dashboard things that mostly seem unrelated as well, but there is one about the labels argument you may want to check out before merging, see https://github.com/dianna-ai/dianna/actions/runs/3655705906/jobs/6177325029#step:4:13
cwmeijer
added this to Ready for review
in Sprint 24: Research relevance maps properties; XAI methods for TS implementatation start
|
Signed commits issue. @cwmeijer would you know how to merge this one? |
cwmeijer
moved this from Ready for review
to Done
in Sprint 24: Research relevance maps properties; XAI methods for TS implementatation start
I changed the signatures of all explain_image or explain_text definitions. I changed the label kwarg into a positional argument. No need for error checking because it is now automatically a TypeError to call any of those methods without a labels argument.