Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make label a required argument #131

Closed
loostrum opened this issue Jan 24, 2022 · 2 comments
Closed

Make label a required argument #131

loostrum opened this issue Jan 24, 2022 · 2 comments

Comments

@loostrum
Copy link
Member

Now the label argument is a keyword argument with a default of either 0 or 1, depending on the method.
Doesn't it make more sense to always ask the user which class they want an explanation for instead of assuming one?

@egpbos
Copy link
Member

egpbos commented Jan 24, 2022

Sounds reasonable to me.

I'm thinking that refactoring the classes into more specific ones that also mention what task they do, so e.g. LimeImageClassifier ([name][modality][task]) as mentioned in #91 (comment), would also support this way of working. It should immediately be clear from the name Classifier that a class to explain must be provided. Similarly, for possible other tasks in the future, other arguments may be clear (e.g. a distance metric when you want to explain distance).

@cwmeijer
Copy link
Contributor

cwmeijer commented Dec 9, 2022

See PR #426.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request old: should have
Development

No branches or pull requests

4 participants