chore: remove fetching of schemas and use the data engine instead for api requests #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3197--dhis2-maps.netlify.app |
3 flaky tests on run #3240 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Thematic Layers > adds a thematic layer with split view period |
Screenshots
|
|
dataDownload.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Data Download > downloads data from a thematic layer |
Screenshots
|
|
basemaps.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Basemap checks > open map with unknown basemap uses fallback basemap (OSM Light) when system default basemap is invalid |
Screenshots
|
|
Review all test suite changes for PR #3197 ↗︎
…-app into chore/remove-unneeded-schemas
jenniferarnesen
changed the title
…3255) * chore: remove schemas * chore: programs was already switched to app-runtime * chore: pass engine for use by getEventColumns * chore: try enabling cypress test for event data table * chore: use event layer with less data so cypress doesnt crash
jenniferarnesen
changed the title
jenniferarnesen
changed the title
janhenrikoverland
approved these changes
Aug 12, 2024
…-app into chore/remove-unneeded-schemas
dhis2-bot
added a commit
that referenced
this pull request
Aug 19, 2024
## [100.6.4](v100.6.3...v100.6.4) (2024-08-19) ### Bug Fixes * schemas were unnecessarily loaded and taking up valuable bandwidth ([#3197](#3197)) ([4b8dd61](4b8dd61))
|
🎉 This PR is included in version 100.6.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all the schemas.
Where needed, d2 was replaced with data engine from app-runtime.
GroupStyle - change of image path works:
