Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove orgUnit, orgUnitGroup, program, programStage schemas #3255

Merged

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Jun 18, 2024

Removed schemas:

  • organisationUnit
  • organisationUnitGroup
  • program
  • programStage

Relevant parts of the app to test:

  • Data download of an event layer
  • Data table with event layer

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 18, 2024

🚀 Deployed on https://pr-3255--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 18, 2024 14:55 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify June 18, 2024 15:02 Inactive
@jenniferarnesen jenniferarnesen changed the title chore: remove schemas chore: remove orgUnit, orgUnitGroup, program, programStage schemas Aug 2, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify August 2, 2024 12:26 Inactive
@BRaimbault
Copy link
Collaborator

BRaimbault commented Aug 7, 2024

Testing with "Inpatient morbidity and mortality" in https://test.e2e.dhis2.org/analytics-2.40

Downloading data seems to work fine.

I see the data table is not showing the data elements marked to "show in report" (Mode of discharge, Age and Diagnosis) and an error is thrown (An unknown error occurred while reading layer data).

Before:
image

After:
image

src/util/event.js Show resolved Hide resolved
@dhis2-bot dhis2-bot temporarily deployed to netlify August 7, 2024 09:35 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 7, 2024 10:07 Inactive
@jenniferarnesen jenniferarnesen merged commit 9bb2645 into chore/remove-unneeded-schemas Aug 8, 2024
21 checks passed
@jenniferarnesen jenniferarnesen deleted the chore/remove-even-more-schemas branch August 8, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants