Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Java 11 #393

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Build with Java 11 #393

merged 2 commits into from
Feb 11, 2024

Conversation

ochedru
Copy link
Collaborator

@ochedru ochedru commented Feb 10, 2024

No description provided.

@hrstoyanov
Copy link

hrstoyanov commented Feb 11, 2024

@ochedru Thanks for doing this!
The code change looks good, one question though:
You have org.dhatim.fastexcel.reader but then I see org.dhatim.fastexcel instead of org.dhatim.fastexcel.writer ?

Btw, if you later decide to implement a complete modularization, I will help.

When do you plan on deploying a new version with this change in?

@ochedru
Copy link
Collaborator Author

ochedru commented Feb 11, 2024

@hrstoyanov The writer module artifact id is actually org.dhatim.fastexcel (originally, fastexcel was built only to write Excel files). However, I am not sure if this has to match Automatic-Module-Name?
As soon as the PR is ok for you, I merge it and release version 0.17.0.

@hrstoyanov
Copy link

The module names don't matter that much, go ahead and release the new version, please

@ochedru ochedru merged commit 6968378 into dhatim:master Feb 11, 2024
1 check passed
@ochedru ochedru deleted the task/build-with-java-11 branch February 11, 2024 18:57
dwickern added a commit to dwickern/fastexcel that referenced this pull request Feb 19, 2024
Java 11 is required since dhatim#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants