Why is fastexcel not modularized (Java 9 module system) yet?

[hrstoyanov]

Not only that, but the jars (fastexecl-reader-x.x.x.jar) do not even have MANIFEST !? Unfortunately this becomes show-stopper issue when combined with a bug that Gradle has not fixed even today.

@ochedru , please, if you don't want to put the effort and modularize fastexcel properly, at least add MANIFEST in the jars with the below, for example:

Automatic-Module-Name: org.dhatim.fastexcel.reader

[ochedru]

Thank you for reporting this. I opened #393 to build with Java 11 and add Automatic-Module-Name to manifests. Could you please review this PR?

[ochedru]

Done. Please let me know if version 0.17.0 works for you.

[hrstoyanov]

Thanks you @ochedru !
It works, but you may want to document for users that will use fastexel as a Java module - their module definition would need to be like this:

module xyz.mymodule {
    requires org.dhatim.fastexcel.reader;
    requires org.apache.commons.compress;
}

because the excel reader module is not fully implemented (we just added a manifest workaround) and therefore it does not automatically bring in its transitive dependencies, such as the Apache's common compress module.

If you have time in future, and add proper module-info.java, only this would be requred:

module xyz.mymodule {
    requires org.dhatim.fastexcel.reader;
}

[ochedru]

Ok thanks. I added the help-wanted label to this issue, in case someone knowledgeable wants to open a PR to complete the modularization.

[charphi]

Ok thanks. I added the help-wanted label to this issue, in case someone knowledgeable wants to open a PR to complete the modularization.

Done in #395

Note that I have reverted to Java8 minimum requirement (because I need it in one of my projects) but the package is still fully compliant with Java9+ modules.

There is a build warning on opczip dependency because it has an automatic module name. I will make a PR on this project to fix it when I have time :)