Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: nano (original, plain, plain-wordmark) #1619

Merged
merged 3 commits into from
Feb 3, 2023
Merged

update icon: nano (original, plain, plain-wordmark) #1619

merged 3 commits into from
Feb 3, 2023

Conversation

ConX
Copy link
Contributor

@ConX ConX commented Jan 8, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR closes NONE

Notes

I am not sure what was wrong with the previous version. After exporting with Adobe Illustrator, it worked.

@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'Update nano icon'

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@lunatic-fox lunatic-fox changed the title Update nano icon update icon: nano (original, original-wordmark) Jan 9, 2023
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jan 9, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nano-original-wordmark.svg looks good, just need to be minified.

In the original issue you also mentioned that nano-original.svg has the same issue with icomoon, if that's the case, then that should be updated here too, right?

I am not sure what was wrong with the previous version. After exporting with Adobe Illustrator, it worked.

Hmm, odd. Great that it was easily fixable though! :D

icons/nano/nano-original-wordmark.svg Outdated Show resolved Hide resolved
@lunatic-fox
Copy link
Contributor

Hello there!

I think we can preserve the original and original-wordmark as it is and create a plain and plain-wordmark to use them as font.

My idea is to do a filled η like their favicon as plain version and η GNU nano as the plain-wordmark the same way.

Some topics:

  • original work as a font character, but it's size is 126kB.
  • Old original-wordmark "blocks" the font build, making all icons unable to be displayed.
  • New original-wordmark doesn't show up, but the font build runs fine.

Some smoothing happened in the new original-wordmark, but the file yet to big (181kB) to be rendered properly as a font character.

I'll be very busy this month, so if this idea is ok, it'll be really great if you can make it. Otherwise, I'll be doing that as soon as possible. 🤩

@Snailedlt
Copy link
Collaborator

@lunatic-fox I think the idea is good. Not ideal, but it's better than a crashing fontset.
Looks like you'll be the one to implement this, so let me know if you need any help with it, and ofc set me up as reviewer when the time comes :)

@lunatic-fox
Copy link
Contributor

Hello there!
Here are some options.

Solid Solid wordmark
Striped Striped wordmark

@Snailedlt
Copy link
Collaborator

@lunatic-fox Both look good! I think the striped ones look better, but feel free to choose the one you like best here :)

@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox changed the title update icon: nano (original, original-wordmark) update icon: nano (original, plain, plain-wordmark) Feb 3, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for making the issue and PR @ConX and thank you for updating the plain icons @lunatic-fox

@Snailedlt Snailedlt merged commit 9985af5 into devicons:develop Feb 3, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants