Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] HELM and nano icons do not build on IcoMoon #1613

Closed
1 task done
ConX opened this issue Jan 6, 2023 · 1 comment
Closed
1 task done

[BUG] HELM and nano icons do not build on IcoMoon #1613

ConX opened this issue Jan 6, 2023 · 1 comment
Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet

Comments

@ConX
Copy link
Contributor

ConX commented Jan 6, 2023

I have searched through the issues and didn't find my problem.

  • Confirm

Bug description

When trying to build the font for the current develop branch, I found that the HELM and nano icons introduce issues.

Specifically, the nano icons (nano-original.svg, nano-original-wordmark.svg), completely break the IcoMoon font generation step, as shown below:

image

On the other hand, the HELM icon results to the following alert from IcoMoon:

image

When generating the font with the HELM icon selected, IcoMoon asks for it to be deselected before proceeding.

Possible fixes or solutions

  • Delete icons from the develop branch
  • Add to the automation the appropriate checks, if those haven't been added since those icons were merged to develop.

Additional information

No response
@ConX ConX added the bug Use this label for pointing out bugs label Jan 6, 2023
This was referenced Jan 8, 2023
Merged
Merged
@ConX
Copy link
Contributor Author

ConX commented Jan 8, 2023

If both #1618 and #1619 are merged, then this should be closed.

@Snailedlt Snailedlt mentioned this issue Feb 3, 2023
Closed
Snailedlt pushed a commit that referenced this issue Feb 3, 2023
@ConX @lunatic-fox
update icon: nano (original, plain, plain-wordmark) (#1619)
9985af5 
* Update nano icon to fix #1613

* Add `plain` and `plain-wordmark` versions

* Update nano-original-wordmark.svg

---------

Co-authored-by: unknown <joseliojrx25@gmail.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
@Panquesito7 Panquesito7 added the in-develop The fix/feature is present in `develop` branch but not merged into `master` yet label Feb 8, 2023
@github-actions github-actions bot closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet
Projects
Devicons to-do
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ConX @Panquesito7