fix: debounce userSettings update
#9220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9220 +/- ##
===========================================
- Coverage 44.70% 41.57% -3.14%
===========================================
Files 1270 515 -755
Lines 155130 50040 -105090
Branches 2437 0 -2437
===========================================
- Hits 69351 20802 -48549
+ Misses 85543 29238 -56305
+ Partials 236 0 -236
Flags with carried forward coverage won't be shown. Click here to find out more. |
thiagodallacqua-hpe
approved these changes
Apr 23, 2024
ashtonG
added a commit
that referenced
this pull request
Jun 13, 2024
This pr solves some race conditions that were added in #9220 by undoing the global settings debounce and instead localizing it to the column width changes the bug was talking about. There's a light refacator of `userSettings#setPartial` which should allow it to work on any io-ts type that has props.
ashtonG
added a commit
that referenced
this pull request
Jun 13, 2024
This pr solves some race conditions that were added in #9220 by undoing the global settings debounce and instead localizing it to the column width changes the bug was talking about. There's a light refacator of `userSettings#setPartial` which should allow it to work on any io-ts type that has props.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-187
ET-191
Description
Test Plan
users/settingare not called many times during the new experiment table column width resizeusers/settinginFast 3GnetworkChecklist
docs/release-notes/.See Release Note for details.