Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass correct master scheme to genai #9181

Merged
merged 2 commits into from
Apr 17, 2024
Merged

chore: pass correct master scheme to genai #9181

merged 2 commits into from
Apr 17, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Apr 17, 2024

Ticket

GAS-675

Description

When using .Values.useNodePortForMaster=false with a tlsSecret for the master node, determined creates a service LoadBalancer that is only accessible by explicitly using "https". This makes sure the right scheme is conveyed to the genai backend.

Test Plan

Should not need to be validated in release party. The GenAI team is validating it separately.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c0a557f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6620143e0a75660008245048

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.52%. Comparing base (1037d83) to head (c0a557f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9181      +/-   ##
==========================================
- Coverage   45.44%   41.52%   -3.92%     
==========================================
  Files        1197     1169      -28     
  Lines      147558   145781    -1777     
  Branches     2437     2438       +1     
==========================================
- Hits        67051    60532    -6519     
- Misses      80275    85017    +4742     
  Partials      232      232              
Flag Coverage Δ
backend 43.75% <ø> (-0.03%) ⬇️
harness 49.53% <ø> (-14.29%) ⬇️
web 35.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 161 files with indirect coverage changes

@tayritenour tayritenour merged commit 0765e38 into main Apr 17, 2024
80 of 92 checks passed
@tayritenour tayritenour deleted the GAS-675 branch April 17, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants