chore: pass correct master scheme to genai (#9181)

determined-ai · Apr 17, 2024 · 0765e38 · 0765e38
1 parent 26f5e0b
commit 0765e38
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/helm/charts/determined/templates/_helpers.tpl b/helm/charts/determined/templates/_helpers.tpl
@@ -30,3 +30,13 @@
     {{- end }}
     {{ toJson $resource_pools }}
 {{- end }}
+
+{{- /* Necessary because of the way that useNodePortForMaster makes a LoadBalancer that only allows */ -}}
+{{- /* https connections through */ -}}
+{{- define "genai.detMasterScheme" -}}
+    {{- if (and (not .Values.useNodePortForMaster) .Values.tlsSecret) }}
+        {{- "https" }}
+    {{- else }}
+        {{- "http" }}
+    {{- end }}
+{{- end }}
diff --git a/helm/charts/determined/templates/genai/genai-deployment.yaml b/helm/charts/determined/templates/genai/genai-deployment.yaml
@@ -29,7 +29,7 @@ spec:
         imagePullPolicy: "Always"
         env:
           - name: DET_MASTER
-            value: determined-master-service-{{ .Release.Name }}:{{ .Values.masterPort }}
+            value: {{ include "genai.detMasterScheme" . }}://determined-master-service-{{ .Release.Name }}.{{ .Release.Namespace }}:{{ .Values.masterPort }}
           - name: DB_NAME
             value: lore
           - name: DB_USER
@@ -70,6 +70,7 @@ spec:
           {{- end }}
           - name: genai-resource-pool-metadata
             mountPath: /run/determined/workdir/rp_config
+            readOnly: true
         resources:
           requests:
             {{- if .Values.genai.cpuRequest }}