Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix docs and wording [DET-10234] #9179

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Apr 16, 2024

Ticket

DET-10234

Description

Test Plan

No testing required

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 16, 2024
@determined-ci determined-ci requested a review from a team April 16, 2024 21:34
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit ea1d7e3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/661eeeed424bb200082ac49f
😎 Deploy Preview https://deploy-preview-9179--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salonig23 salonig23 marked this pull request as ready for review April 16, 2024 21:35
@salonig23 salonig23 requested review from a team as code owners April 16, 2024 21:35
@salonig23 salonig23 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.47%. Comparing base (5541e54) to head (ea1d7e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9179   +/-   ##
=======================================
  Coverage   45.46%   45.47%           
=======================================
  Files        1197     1197           
  Lines      147556   147556           
  Branches     2438     2438           
=======================================
+ Hits        67092    67104   +12     
+ Misses      80232    80220   -12     
  Partials      232      232           
Flag Coverage Δ
backend 43.70% <ø> (+0.02%) ⬆️
harness 64.02% <ø> (+<0.01%) ⬆️
web 35.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/cli/experiment.py 17.88% <ø> (ø)
harness/determined/cli/trial.py 17.85% <ø> (ø)

... and 4 files with indirect coverage changes

@salonig23 salonig23 merged commit d41c4a7 into main Apr 16, 2024
81 of 93 checks passed
@salonig23 salonig23 deleted the fix-docs-log-retention branch April 16, 2024 21:53
@salonig23 salonig23 changed the title fix: fix docs and wording fix: fix docs and wording [DET-10234] Apr 16, 2024
keita-determined pushed a commit that referenced this pull request Apr 17, 2024
(cherry picked from commit d41c4a7)
JComins000 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants