fix: fix docs and wording (#9179)

docs/reference/experiment-config-reference.rst

@@ -333,7 +333,7 @@ Parameters include:
    retention settings post-completion for a single trial or the entire experiment, you can use the
    CLI command ``det t set log-retention <trial-id>`` or ``det e set log-retention <exp-id>``. Both
    commands accept either the argument: ``--days``, which sets the number of days to retain logs
-   from the time of creation, or ``--forever`` which retains logs indefinitely.
+   from the end time of the task, or ``--forever`` which retains logs indefinitely.
 
 Example configuration:
 

harness/determined/cli/experiment.py

@@ -572,7 +572,7 @@ def set_log_retention(args: argparse.Namespace) -> None:
     if not args.forever and not isinstance(args.days, int):
         raise cli.CliError(
             "Please provide an argument to set log retention. --days sets the number of days to"
-            " retain logs from the time of creation, eg. `det e set log-retention 1 --days 50`."
+            " retain logs from the end time of the task, eg. `det e set log-retention 1 --days 50`."
             " --forever retains logs indefinitely, eg.`det e set log-retention 1 --forever`."
         )
     elif isinstance(args.days, int) and (args.days < -1 or args.days > 32767):
@@ -1332,8 +1332,8 @@ def experiment_id_arg(help: str) -> cli.Arg:  # noqa: A002
                             cli.Arg(
                                 "--days",
                                 type=none_or_int,
-                                help="from the time of creation, number of days to "
-                                "retain the logs for. allowed range: -1 to 32767.",
+                                help="number of days to retain the logs for, from the "
+                                "end time of the task, . allowed range: -1 to 32767.",
                             ),
                             cli.Arg(
                                 "--forever",

harness/determined/cli/trial.py

@@ -243,7 +243,7 @@ def set_log_retention(args: argparse.Namespace) -> None:
     if not args.forever and not isinstance(args.days, int):
         raise cli.CliError(
             "Please provide an argument to set log retention. --days sets the number of days to"
-            " retain logs from the time of creation, eg. `det t set log-retention 1 --days 50`."
+            " retain logs from the end time of the task, eg. `det t set log-retention 1 --days 50`."
             " --forever retains logs indefinitely, eg.`det t set log-retention 1 --forever`."
         )
     elif isinstance(args.days, int) and (args.days < -1 or args.days > 32767):
@@ -538,8 +538,8 @@ def create_json_file_in_dir(content: Any, file_path: str) -> None:
                                 cli.Arg(
                                     "--days",
                                     type=none_or_int,
-                                    help="from the time of creation, number of days to "
-                                    "retain the logs for. allowed range: -1 to 32767.",
+                                    help="number of days to retain the logs for, from the "
+                                    "end time of the task, . allowed range: -1 to 32767.",
                                 ),
                                 cli.Arg(
                                     "--forever",

proto/src/determined/api/v1/experiment.proto

@@ -156,7 +156,7 @@ message PutExperimentRetainLogsRequest {
   // The ID of the experiment.
   int32 experiment_id = 1;
 
-  // The number of days to retain logs, starting from the time of creation.
+  // The number of days to retain logs, starting from the end time of the task.
   int32 num_days = 2;
 }
 
@@ -170,7 +170,7 @@ message PutExperimentsRetainLogsRequest {
   };
   // The ids of the experiments being moved.
   repeated int32 experiment_ids = 1;
-  // The number of days to retain logs, starting from the time of creation.
+  // The number of days to retain logs, starting from the end time of the task.
   int32 num_days = 2;
   // Targets all experiments matching filters.
   BulkExperimentFilters filters = 3;

proto/src/determined/api/v1/trial.proto

@@ -460,7 +460,7 @@ message PutTrialRetainLogsRequest {
   // The ID of the trial.
   int32 trial_id = 1;
 
-  // The number of days to retain logs, starting from the time of creation.
+  // The number of days to retain logs, starting from the end time of the task.
   int32 num_days = 2;
 }