feat: log podspec [DET-9861] #8899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
NicholasBlaskey
approved these changes
Feb 26, 2024
| @@ -480,6 +481,7 @@ func (p *pod) createPodSpec(scheduler string) error { | |||
|
|
|||
| p.pod = p.configurePodSpec( | |||
| volumes, initContainer, container, sidecars, (*k8sV1.Pod)(env.PodSpec()), scheduler) | |||
| p.insertLog(time.Now().UTC(), fmt.Sprintf("Pod Spec Configured:\n%v\n", p.pod.Spec)) | |||
There was a problem hiding this comment.
is the message obnoxiously large? Like do you think it could be annoying for some users?
Maybe we could add the log at a debug level?
There was a problem hiding this comment.
I'm afraid that if we log it at the debug level it might not be useful enough in a lot of situations. I personally don't think it's too obnoxious, but what do you think? (I'll add a screenshot)
imo it's like how in master logs we print the master spec at startup
eecsliu
force-pushed
the
eliu-log-podspec
branch
from
d1c3e74
to
ae60716
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8899 +/- ##
==========================================
- Coverage 47.53% 44.22% -3.31%
==========================================
Files 1066 706 -360
Lines 170248 133397 -36851
Branches 2235 2235
==========================================
- Hits 80919 59000 -21919
+ Misses 89171 74239 -14932
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
eecsliu
force-pushed
the
eliu-log-podspec
branch
from
ae60716
to
eaecd42
Compare
This was referenced Feb 28, 2024
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply prints out the podspec before the task is run. The message occurs at the start of the task and doesn't interfere with the task logs.
Test Plan
Manually verify: run a task in kubernetes and check that the logs include a string of the podspec.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket