test: fix failing Go TestResourceCreationFailed test #8918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8918 +/- ##
==========================================
- Coverage 48.42% 47.17% -1.25%
==========================================
Files 743 1154 +411
Lines 136157 175073 +38916
Branches 2237 2237
==========================================
+ Hits 65929 82585 +16656
- Misses 70070 92330 +22260
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
approved these changes
Feb 28, 2024
stoksc
reviewed
Feb 28, 2024
|
|
||
| message = sub.Get() | ||
| require.IsType(t, &sproto.ContainerLog{}, message) | ||
| require.Contains(t, *message.(*sproto.ContainerLog).AuxMessage, "already exists") |
There was a problem hiding this comment.
part of k8s improvements should definitely be improving these tests. this is really fragile.
There was a problem hiding this comment.
like I don't even know what this test is really testing anyway at this point, the error comes from our mock...
I don't know
They have just been like touched just enough so they pass on every change so I think they are basically meaningless at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix failing test on main
https://app.circleci.com/pipelines/github/determined-ai/determined/51712/workflows/bdcbdfb7-e33a-4526-98d1-a261538687bd/jobs/2304253
Caused by
#8899
Test Plan
Intg passes
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket