chore: react-virtuoso LogViewer companion #8862
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilyBonar
force-pushed
the
emilybonar/new-logviewer
branch
2 times, most recently
from
0afd7a6
to
e02eb46
Compare
|
iirc, we wanna resolve the double scrollbar issue, right (or is it out of scope)? i see this bug in latest main, so not from this PR, but do you intend to fix this bug in this PR? The test plan scope isnt clear. 
also, i saw some test failures. |
|
Noticed that |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8862 +/- ##
==========================================
- Coverage 47.35% 42.55% -4.80%
==========================================
Files 1162 842 -320
Lines 176133 136781 -39352
Branches 2237 2233 -4
==========================================
- Hits 83402 58211 -25191
+ Misses 92573 78412 -14161
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
EmilyBonar
force-pushed
the
emilybonar/new-logviewer
branch
from
368938d
to
b667910
Compare
There was a problem hiding this comment.
Mostly good, but found the following bugs. Tested on Chrome
After pushing Scroll the oldest, i cant scroll down to the newest.
Screen.Recording.2024-02-26.at.1.34.07.PM.mov
There are double scrollbars with small viewport,.
Screen.Recording.2024-02-26.at.1.29.21.PM.mov
nit: In the full view, there is bottom margin. (see it in the latest-main website so can be ignored)
|
@keita-determined First bug should be fixed. The double scrollbar seems to be an issue with how the site as a whole handles resizing. In the last screenshot, I'm not sure what the issue is. The 16px margin is intentional and comes from Page. |
There was a problem hiding this comment.
confirmed the first bug is fixed, and lets skip other 2 bugs as you said its not directly related to the pr.
idk why this happens, but it only happens on this branch. prob hew change caused this?
iirc, it was working for the commit, but now cannot search by text and/or dropdown filters
Screen.Recording.2024-03-04.at.4.07.45.PM.mov
webui/react/package.json
Outdated
| @@ -46,7 +46,7 @@ | |||
| "fp-ts": "^2.16.1", | |||
| "fuse.js": "^7.0.0", | |||
| "hermes-parallel-coordinates": "^0.6.17", | |||
| "hew": "npm:@hpe.com/hew@^0.6.31", | |||
| "hew": "github:determined-ai/hew.git#5eb7c907e0b69e9480c8dbc2d1a023a3483f74b0", | |||
There was a problem hiding this comment.
nit: please make sure to use npm instead of commit hash before merging this PR
EmilyBonar
force-pushed
the
emilybonar/new-logviewer
branch
from
f72aedc
to
b3c6bdf
Compare
|
@keita-determined That search bug seems like a blocker, but I'm not able to repro it. Did you do anything special/unusual? |
i first typed |
|
@keita-determined Good catch, seem like there was a bug regarding resetting our list of IDs for dupe detection. Try it now and it should work. |
|
yep, it works now |
And the quarantine workflow along with. We've decided as a company that future flaky tests will be skipped rather than quarantined until they're fixed. Last test run as part of the quarantine suite is being removed as part of #8862, and is not needed even before that PR lands.
And the quarantine workflow along with. We've decided as a company that future flaky tests will be skipped rather than quarantined until they're fixed. Last test run as part of the quarantine suite is being removed as part of #8862, and is not needed even before that PR lands.
Description
This is a companion PR to determined-ai/hew#110.
Test Plan
Check Trial Logs, Task Logs, and Cluster Logs to ensure they all work as expected.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket