Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove last quarantined test #8922

Merged
merged 1 commit into from
Mar 6, 2024
Merged

test: remove last quarantined test #8922

merged 1 commit into from
Mar 6, 2024

Conversation

wes-turner
Copy link
Contributor

@wes-turner wes-turner commented Feb 28, 2024

And the quarantine workflow along with. We've decided as a company that future flaky tests will be skipped rather than quarantined until they're fixed.

Last test run as part of the quarantine suite is being removed as part of #8862, and is not needed even before that PR lands.

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

And the quarantine workflow along with.
@cla-bot cla-bot bot added the cla-signed label Feb 28, 2024
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 59ea627
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65dfb61ec8e27400080b27d7

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.17%. Comparing base (3a3b668) to head (59ea627).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8922   +/-   ##
=======================================
  Coverage   47.17%   47.17%           
=======================================
  Files        1154     1154           
  Lines      175089   175089           
  Branches     2235     2237    +2     
=======================================
  Hits        82600    82600           
  Misses      92331    92331           
  Partials      158      158           
Flag Coverage Δ
backend 42.27% <ø> (ø)
harness 63.72% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@wes-turner wes-turner marked this pull request as ready for review March 5, 2024 18:31
@wes-turner wes-turner requested a review from a team as a code owner March 5, 2024 18:31
@wes-turner wes-turner merged commit 4d538ae into main Mar 6, 2024
74 of 86 checks passed
@wes-turner wes-turner deleted the wes/kill-quarantine branch March 6, 2024 18:36
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
And the quarantine workflow along with. We've decided as a company that future flaky tests will be skipped rather than quarantined until they're fixed.

Last test run as part of the quarantine suite is being removed as part of #8862, and is not needed even before that PR lands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants