test: do not import model_hub test requirements #8771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8771 +/- ##
==========================================
- Coverage 47.42% 44.26% -3.17%
==========================================
Files 1047 1019 -28
Lines 166976 165251 -1725
Branches 2242 2242
==========================================
- Hits 79188 73144 -6044
- Misses 87629 91948 +4319
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. |
kkunapuli
changed the title
kkunapuli
changed the title
kkunapuli
commented
Jan 29, 2024
| cat <<parameters.extra-requirements-file>> >> /tmp/cachefile | ||
| for i in <<parameters.extra-requirements-file>>; do | ||
| cat $i >> /tmp/cachefile | ||
| done |
There was a problem hiding this comment.
allow multiple requirements files to be specified; we want multiple requirements.txt files for model_hub CI test purposes, but not in the build
ioga
approved these changes
Jan 29, 2024
djanicekpach
approved these changes
Jan 30, 2024
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
* Do not import model_hub test requirements * test: do not import model_hub test requirements * include model_hub as additional requirements file * try allowing multiple additional requirements files * use variable in for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Model_hub tests require building tokenizers, that are pinned to an older version and require a now old version of the rust compiler. Remove the requirement for local development; the CI imports the requirement independently.
Test Plan
Confirm all CI tests complete successfully.
Commentary (optional)
Context: https://hpe-aiatscale.slack.com/archives/CSG3W08JY/p1706227736615449?thread_ts=1691690041.149519&cid=CSG3W08JY
Checklist
docs/release-notes/.See Release Note for details.