Skip to content

Commit

Permalink
test: do not import model_hub test requirements (#8771)
Browse files Browse the repository at this point in the history
* Do not import model_hub test requirements

* test: do not import model_hub test requirements

* include model_hub as additional requirements file

* try allowing multiple additional requirements files

* use variable in for loop
  • Loading branch information
kkunapuli authored Jan 30, 2024
1 parent 1e2da10 commit 98c61f3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
10 changes: 7 additions & 3 deletions .circleci/real_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,9 @@ commands:
fi
echo <<parameters.extras-requires>> >> /tmp/cachefile
if [ -n <<parameters.extra-requirements-file>> ]; then
cat <<parameters.extra-requirements-file>> >> /tmp/cachefile
for i in <<parameters.extra-requirements-file>>; do
cat $i >> /tmp/cachefile
done
fi
echo '<<parameters.python-version>>' >> /tmp/cachefile
echo '<<parameters.install-python>>' >> /tmp/cachefile
Expand Down Expand Up @@ -466,7 +468,9 @@ commands:
name: Install <<parameters.extra-requirements-file>>
command: |
if [ -n "<<parameters.extra-requirements-file>>" ]; then
tools/scripts/retry.sh pip install -r <<parameters.extra-requirements-file>>
for i in <<parameters.extra-requirements-file>>; do
tools/scripts/retry.sh pip install -r $i
done
fi
- save_cache:
key: det-python-deps-<<pipeline.parameters.cache-buster>>-{{ checksum "/tmp/cachefile" }}
Expand Down Expand Up @@ -1792,7 +1796,7 @@ jobs:
install-python: false
determined: true
model-hub: true
extra-requirements-file: "requirements.txt"
extra-requirements-file: "requirements.txt model_hub/tests/requirements.txt"
executor: <<pipeline.parameters.docker-image>>
- run: make -C harness check
- run: make -C model_hub check
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
-e model_hub
-r docs/requirements.txt
-r harness/tests/requirements/requirements-harness.txt
-r model_hub/tests/requirements.txt
-r e2e_tests/tests/requirements.txt
-r bindings/requirements.txt

Expand Down

0 comments on commit 98c61f3

Please sign in to comment.