fix: remove extra quotes around IdentifyTask (#8792)

determined-ai · Feb 7, 2024 · 56e7000 · 56e7000
1 parent 3805ebd
commit 56e7000
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/docs/release-notes/identify-task.rst b/docs/release-notes/identify-task.rst
@@ -0,0 +1,6 @@
+:orphan:
+
+**Bug Fixes**
+
+-  TensorBoard: For TensorBoard task types, fix a bug that would allow users to view TensorBoards,
+      even if they did not have permission to view the all workspaces it included.
diff --git a/master/internal/command/postgres_command.go b/master/internal/command/postgres_command.go
@@ -47,9 +47,7 @@ func IdentifyTask(ctx context.Context, taskID model.TaskID) (TaskMetadata, error
 	metadata := TaskMetadata{}
 	if err := db.Bun().NewSelect().Model(&metadata).
 		ColumnExpr("generic_command_spec->'Metadata'->'workspace_id' AS workspace_id").
-		// TODO(DET-10004) TaskType needs
-		// to have ->> instead of -> so task_type doesn't get surrounded by double quotes.
-		ColumnExpr("generic_command_spec->'TaskType' as task_type").
+		ColumnExpr("generic_command_spec->>'TaskType' as task_type").
 		ColumnExpr("generic_command_spec->'Metadata'->'experiment_ids' as experiment_ids").
 		ColumnExpr("generic_command_spec->'Metadata'->'trial_ids' as trial_ids").
 		Where("task_id = ?", taskID).

diff --git a/master/internal/command/postgres_command_intg_test.go b/master/internal/command/postgres_command_intg_test.go
@@ -5,7 +5,6 @@ package command
 
 import (
 	"context"
-	"fmt"
 	"log"
 	"os"
 	"testing"
@@ -67,8 +66,7 @@ func TestIdentifyTask(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, TaskMetadata{
 		WorkspaceID: 1,
-		// TODO(DET-10004) remove these double quotes.
-		TaskType: model.TaskType(fmt.Sprintf(`"%s"`, model.TaskTypeCommand)),
+		TaskType:    model.TaskTypeCommand,
 	}, meta)
 
 	// Tensorboard.
@@ -84,9 +82,8 @@ func TestIdentifyTask(t *testing.T) {
 	meta, err = IdentifyTask(ctx, tensorboardID)
 	require.NoError(t, err)
 	require.Equal(t, TaskMetadata{
-		WorkspaceID: 1,
-		// TODO(DET-10004) remove these double quotes.
-		TaskType:      model.TaskType(fmt.Sprintf(`"%s"`, model.TaskTypeTensorboard)),
+		WorkspaceID:   1,
+		TaskType:      model.TaskTypeTensorboard,
 		ExperimentIDs: []int32{int32(expIDs[0]), int32(expIDs[1])},
 		TrialIDs:      []int32{int32(trialIDs[0]), int32(trialIDs[1])},
 	}, meta)