Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra quotes around IdentifyTask #8792

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented Feb 2, 2024

Description

Remove extra quotes around TaskType from IdentifyTask -- fix the corresponding intg test to match this.

These changes will affect api_auth.go in the following code block:

if spec.TaskType == model.TaskTypeTensorboard {
		err = command.AuthZProvider.Get().CanGetTensorboard(...)
	} else {
		err = command.AuthZProvider.Get().CanGetNSC(...)
	}

The 'if' block would never be true before, but now it can be.

Test Plan

Run intg tests.

Commentary (optional)

We could test this feature's effect in api_auth.go by duplicating the processProxyAuthentication, but I believe TestIdentifyTask suffices when we replace the equality check with model.TaskTypeABC exactly. What's important is that the equality check is triggered with the right TaskType (tensorboard), and the postgres intg test also ensures that.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-10004

@cla-bot cla-bot bot added the cla-signed label Feb 2, 2024
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 8dfe7d9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65c3bb05d0b07400082b545a

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1a6e20) 47.72% compared to head (8dfe7d9) 43.25%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8792       +/-   ##
===========================================
- Coverage   47.72%   43.25%    -4.48%     
===========================================
  Files        1049      331      -718     
  Lines      167258    34448   -132810     
  Branches     2243        0     -2243     
===========================================
- Hits        79817    14899    -64918     
+ Misses      87283    19549    -67734     
+ Partials      158        0      -158     
Flag Coverage Δ
harness ?
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/command/postgres_command.go 91.66% <100.00%> (ø)

... and 720 files with indirect coverage changes

@determined-ci determined-ci requested a review from a team February 2, 2024 18:48
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Feb 2, 2024
@carolinaecalderon carolinaecalderon marked this pull request as ready for review February 5, 2024 21:57
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner February 5, 2024 21:57
@carolinaecalderon carolinaecalderon self-assigned this Feb 5, 2024
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

docs/release-notes/identify-task.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@jgongd jgongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes needs to be rewritten

@determined-ci determined-ci requested a review from a team February 7, 2024 17:17
@carolinaecalderon carolinaecalderon merged commit 56e7000 into main Feb 7, 2024
75 of 87 checks passed
@carolinaecalderon carolinaecalderon deleted the 10004-identify-task branch February 7, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants