-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove extra quotes around IdentifyTask #8792
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8792 +/- ##
===========================================
- Coverage 47.72% 43.25% -4.48%
===========================================
Files 1049 331 -718
Lines 167258 34448 -132810
Branches 2243 0 -2243
===========================================
- Hits 79817 14899 -64918
+ Misses 87283 19549 -67734
+ Partials 158 0 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…to 10004-identify-task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release notes needs to be rewritten
Description
Remove extra quotes around TaskType from IdentifyTask -- fix the corresponding intg test to match this.
These changes will affect api_auth.go in the following code block:
The 'if' block would never be true before, but now it can be.
Test Plan
Run intg tests.
Commentary (optional)
We could test this feature's effect in api_auth.go by duplicating the processProxyAuthentication, but I believe TestIdentifyTask suffices when we replace the equality check with
model.TaskTypeABC
exactly. What's important is that the equality check is triggered with the right TaskType (tensorboard), and the postgres intg test also ensures that.Checklist
docs/release-notes/
.See Release Note for details.
Ticket
DET-10004