feat: add transpile_owned and transpile_owned_with_fallback #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Apr 11, 2024
| @@ -146,41 +163,115 @@ impl TranspileOptions { | |||
|
|
|||
| impl ParsedSource { | |||
| /// Transform a TypeScript file into a JavaScript file. | |||
| /// | |||
| /// Note: This will clone the program if it's shared, which | |||
| /// might be expensive. | |||
| pub fn transpile( | |||
There was a problem hiding this comment.
We should probably get rid of this in the future and make it internal. I just wanted to do this in a backwards compatible way for the time being (that said, I also wrote this so we can manually implement transpile_owned_with_fallback and have logging for that, but perhaps we could add logging in here for when it transpiles a non-exclusive ParsedSource)
dsherret
changed the title
bartlomieju
approved these changes
Apr 12, 2024
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @mmastrac
Built this off #236 so waiting on #236.