feat: return structured error from deno_ast::ParsedSource::transpile
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Apr 11, 2024
| @@ -150,11 +165,11 @@ impl ParsedSource { | |||
| &self, | |||
| transpile_options: &TranspileOptions, | |||
| emit_options: &EmitOptions, | |||
| ) -> Result<EmittedSource> { | |||
| ) -> Result<EmittedSource, TranspileError> { | |||
There was a problem hiding this comment.
I did this work as part of another PR to make a transpile_owned(self) method, but then ended up deciding to return the failure of Arc::try_unwrap in the Ok result to force the caller to handle it.
| ParseDiagnostics(#[from] ParseDiagnosticsError), | ||
| #[error(transparent)] | ||
| Swc(#[from] SwcFoldDiagnosticsError), | ||
| } |
There was a problem hiding this comment.
We should switch this to actually use the diagnostics in the future. This is a very rough/sloppy first pass.
bartlomieju
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118