-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update extraEnv to envFrom #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Question: Thoughts on some of these potentially being configMapRef instead of secretRef? I've been in the position before to be product support guy with read access to config maps but not secrets. Do we potentially have that persona who would need to view some of these? |
Potentially - though there is the inverse too where you might want to add a password / secret env var in here as an extra one too - most folks right now using Zarf/UDS will have higher perms because Zarf needs them to do the init process though it is worth considering for the future (I think as Zarf evolves it will introduce different modes, like allowing deployments to go to a single namespace and those features would be drivers for us to change posture). Today though if there was a need a deployer could use the |
🤖 I have created a release *beep* *boop* --- ## [9.7.1-uds.0](v9.6.1-uds.0...v9.7.1-uds.0) (2024-04-19) ### Features * env var MM_SQLSETTINGS_DATASOURCE set ([#54](#54)) ([16894df](16894df)) ### Miscellaneous * **deps:** update mattermost package dependencies ([#48](#48)) ([10b24e9](10b24e9)) * **deps:** update mattermost support dependencies ([#46](#46)) ([2a9d055](2a9d055)) * fix renovate config to only allow semver on mattermost image ([#51](#51)) ([65e294f](65e294f)) * update extraEnv to envFrom ([#58](#58)) ([57df25a](57df25a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [9.7.2-uds.1](v9.7.2-uds.1...v9.7.2-uds.1) (2024-05-10) ### ⚠ BREAKING CHANGES * add monitoring and granular netpols ([#67](#67)) ### Features * add irsa/sa auth support ([f178a54](f178a54)) * add irsa/sa auth support ([c3d5acb](c3d5acb)) * add monitoring and granular netpols ([#67](#67)) ([915eb2d](915eb2d)) * burn the boats ([d25c6bb](d25c6bb)) * env var MM_SQLSETTINGS_DATASOURCE set ([#54](#54)) ([16894df](16894df)) * integrate with keycloak ([#44](#44)) ([ce05b45](ce05b45)) * update readme ([7f5162b](7f5162b)) * Update README.md ([7e9f97b](7e9f97b)) ### Bug Fixes * expose plugin upload setting ([#12](#12)) ([f8fbfc2](f8fbfc2)) * fix mm hostname ([516569a](516569a)) * fix mm hostname and tests ([785384d](785384d)) * fix tests for mm ([c660e66](c660e66)) * handle subdomain shared between packages ([#10](#10)) ([31da0b4](31da0b4)) ### Miscellaneous * add 🏭 to README.md ([9e4c566](9e4c566)) * **deps:** update all dependencies ([#16](#16)) ([e54ebc6](e54ebc6)) * **deps:** update githubactions ([#17](#17)) ([a24855a](a24855a)) * **deps:** update githubactions ([#22](#22)) ([d1cf997](d1cf997)) * **deps:** update mattermost package dependencies ([#42](#42)) ([8da95ef](8da95ef)) * **deps:** update mattermost package dependencies ([#48](#48)) ([10b24e9](10b24e9)) * **deps:** update mattermost package dependencies ([#59](#59)) ([edf154b](edf154b)) * **deps:** update mattermost support dependencies ([#46](#46)) ([2a9d055](2a9d055)) * **deps:** update mattermost support dependencies ([#55](#55)) ([fe798f6](fe798f6)) * **deps:** update mattermost support dependencies ([#63](#63)) ([6010a04](6010a04)) * fix renovate config to only allow semver on mattermost image ([#51](#51)) ([65e294f](65e294f)) * hotfix renovate config registries ([#45](#45)) ([42a912b](42a912b)) * implement upgrade tests for mattermost ([43044cf](43044cf)) * **main:** release 9.3.0-uds.1 ([41da032](41da032)) * **main:** release 9.3.0-uds.2 ([c4381ae](c4381ae)) * **main:** release 9.4.1-uds.0 ([#8](#8)) ([5415a0a](5415a0a)) * **main:** release 9.4.1-uds.1 ([#11](#11)) ([8f73182](8f73182)) * **main:** release 9.4.1-uds.2 ([#13](#13)) ([e177cbe](e177cbe)) * **main:** release 9.4.1-uds.3 ([e57f69a](e57f69a)) * **main:** release 9.4.1-uds.4 ([#40](#40)) ([6c7549f](6c7549f)) * **main:** release 9.6.1-uds.0 ([#47](#47)) ([3e52b95](3e52b95)) * **main:** release 9.7.1-uds.0 ([#52](#52)) ([acda0c5](acda0c5)) * **main:** release 9.7.2-uds.0 ([#60](#60)) ([32eb363](32eb363)) * **main:** release 9.7.2-uds.1 ([#64](#64)) ([fcf56e0](fcf56e0)) * release 9.4.1-uds.0 ([5b89960](5b89960)) * release 9.6.1-uds.0 ([#49](#49)) ([37ef4ad](37ef4ad)) * release as v9.7.2-uds.0 ([#62](#62)) ([bc0b65f](bc0b65f)) * renovate config, remote tasks ([#14](#14)) ([bb6c574](bb6c574)) * standardize repo to template and update README.md ([#20](#20)) ([88a3d84](88a3d84)) * update CODEOWNERS to new style/group ([27246ca](27246ca)) * update extraEnv to envFrom ([#58](#58)) ([57df25a](57df25a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Description
This updates Mattermost to use envFrom instead of extraEnv for greater simplicity and more flexibility.
Related Issue
Fixes #57
Type of change
Checklist before merging