Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: env var MM_SQLSETTINGS_DATASOURCE set #54

Merged
merged 6 commits into from
Apr 19, 2024
Merged

feat: env var MM_SQLSETTINGS_DATASOURCE set #54

merged 6 commits into from
Apr 19, 2024

Conversation

Michael-Kruggel
Copy link
Contributor

@Michael-Kruggel Michael-Kruggel commented Apr 16, 2024 •
edited by corang
Loading

Description

  • Adds a field to add extra environment settings to the Mattermost chart. moved to issue

  • Sets MM_SQLSETTINGS_DATASOURCE so that when restoring from a backed up Mattermost DB snapshot it uses the newest set connection string, instead of the previous one from the database snapshot. For more info, see this issue on the mattermost github.

Related Issue

Fixes mattermost/mattermost#53

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Michael-Kruggel Michael-Kruggel marked this pull request as ready for review April 16, 2024 19:41
@Michael-Kruggel Michael-Kruggel requested a review from a team as a code owner April 16, 2024 19:41
@Michael-Kruggel Michael-Kruggel changed the title feat: Extra env variable and MM_SQLSETTINGS_DATASOURCE env set feat: extra env variable and MM_SQLSETTINGS_DATASOURCE env set Apr 16, 2024
zachariahmiller
zachariahmiller reviewed Apr 16, 2024
View reviewed changes
values/common-values.yaml Outdated Show resolved Hide resolved
values/common-values.yaml Show resolved Hide resolved
Racer159
Racer159 reviewed Apr 17, 2024
View reviewed changes
zarf.yaml Outdated Show resolved Hide resolved
@corang @Racer159
Update zarf.yaml
8f95aa2 
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
@Michael-Kruggel Michael-Kruggel mentioned this pull request Apr 17, 2024
Closed
5 tasks
Racer159
Racer159 requested changes Apr 18, 2024
View reviewed changes
values/common-values.yaml Outdated Show resolved Hide resolved
@corang corang changed the title feat: extra env variable and MM_SQLSETTINGS_DATASOURCE env set feat: MM_SQLSETTINGS_DATASOURCE env set Apr 19, 2024
@corang
Copy link
Contributor

corang commented Apr 19, 2024 •
edited
Loading

Removed the zarf var. We really just needed this db issue fixed, you guys can figure out the env stuff later, it doesn't affect us right now.

@corang corang changed the title feat: MM_SQLSETTINGS_DATASOURCE env set feat: env var MM_SQLSETTINGS_DATASOURCE set Apr 19, 2024
@Michael-Kruggel Michael-Kruggel mentioned this pull request Apr 19, 2024
Closed
@Racer159 Racer159 merged commit 16894df into main Apr 19, 2024
13 of 15 checks passed
@Racer159 Racer159 deleted the feat--extra-env-var branch April 19, 2024 17:07
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Merged
Racer159 pushed a commit that referenced this pull request Apr 19, 2024
@github-actions
chore(main): release 9.7.1-uds.0 (#52)
acda0c5 
🤖 I have created a release *beep* *boop*
---


##
[9.7.1-uds.0](v9.6.1-uds.0...v9.7.1-uds.0)
(2024-04-19)


### Features

* env var MM_SQLSETTINGS_DATASOURCE set
([#54](#54))
([16894df](16894df))


### Miscellaneous

* **deps:** update mattermost package dependencies
([#48](#48))
([10b24e9](10b24e9))
* **deps:** update mattermost support dependencies
([#46](#46))
([2a9d055](2a9d055))
* fix renovate config to only allow semver on mattermost image
([#51](#51))
([65e294f](65e294f))
* update extraEnv to envFrom
([#58](#58))
([57df25a](57df25a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request May 10, 2024
Merged
Racer159 added a commit that referenced this pull request May 10, 2024
@github-actions @Racer159
chore(main): release 9.7.2-uds.1 (#69)
4ad0339 
🤖 I have created a release *beep* *boop*
---


##
[9.7.2-uds.1](v9.7.2-uds.1...v9.7.2-uds.1)
(2024-05-10)


### ⚠ BREAKING CHANGES

* add monitoring and granular netpols
([#67](#67))

### Features

* add irsa/sa auth support
([f178a54](f178a54))
* add irsa/sa auth support
([c3d5acb](c3d5acb))
* add monitoring and granular netpols
([#67](#67))
([915eb2d](915eb2d))
* burn the boats
([d25c6bb](d25c6bb))
* env var MM_SQLSETTINGS_DATASOURCE set
([#54](#54))
([16894df](16894df))
* integrate with keycloak
([#44](#44))
([ce05b45](ce05b45))
* update readme
([7f5162b](7f5162b))
* Update README.md
([7e9f97b](7e9f97b))


### Bug Fixes

* expose plugin upload setting
([#12](#12))
([f8fbfc2](f8fbfc2))
* fix mm hostname
([516569a](516569a))
* fix mm hostname and tests
([785384d](785384d))
* fix tests for mm
([c660e66](c660e66))
* handle subdomain shared between packages
([#10](#10))
([31da0b4](31da0b4))


### Miscellaneous

* add 🏭 to README.md
([9e4c566](9e4c566))
* **deps:** update all dependencies
([#16](#16))
([e54ebc6](e54ebc6))
* **deps:** update githubactions
([#17](#17))
([a24855a](a24855a))
* **deps:** update githubactions
([#22](#22))
([d1cf997](d1cf997))
* **deps:** update mattermost package dependencies
([#42](#42))
([8da95ef](8da95ef))
* **deps:** update mattermost package dependencies
([#48](#48))
([10b24e9](10b24e9))
* **deps:** update mattermost package dependencies
([#59](#59))
([edf154b](edf154b))
* **deps:** update mattermost support dependencies
([#46](#46))
([2a9d055](2a9d055))
* **deps:** update mattermost support dependencies
([#55](#55))
([fe798f6](fe798f6))
* **deps:** update mattermost support dependencies
([#63](#63))
([6010a04](6010a04))
* fix renovate config to only allow semver on mattermost image
([#51](#51))
([65e294f](65e294f))
* hotfix renovate config registries
([#45](#45))
([42a912b](42a912b))
* implement upgrade tests for mattermost
([43044cf](43044cf))
* **main:** release 9.3.0-uds.1
([41da032](41da032))
* **main:** release 9.3.0-uds.2
([c4381ae](c4381ae))
* **main:** release 9.4.1-uds.0
([#8](#8))
([5415a0a](5415a0a))
* **main:** release 9.4.1-uds.1
([#11](#11))
([8f73182](8f73182))
* **main:** release 9.4.1-uds.2
([#13](#13))
([e177cbe](e177cbe))
* **main:** release 9.4.1-uds.3
([e57f69a](e57f69a))
* **main:** release 9.4.1-uds.4
([#40](#40))
([6c7549f](6c7549f))
* **main:** release 9.6.1-uds.0
([#47](#47))
([3e52b95](3e52b95))
* **main:** release 9.7.1-uds.0
([#52](#52))
([acda0c5](acda0c5))
* **main:** release 9.7.2-uds.0
([#60](#60))
([32eb363](32eb363))
* **main:** release 9.7.2-uds.1
([#64](#64))
([fcf56e0](fcf56e0))
* release 9.4.1-uds.0
([5b89960](5b89960))
* release 9.6.1-uds.0
([#49](#49))
([37ef4ad](37ef4ad))
* release as v9.7.2-uds.0
([#62](#62))
([bc0b65f](bc0b65f))
* renovate config, remote tasks
([#14](#14))
([bb6c574](bb6c574))
* standardize repo to template and update README.md
([#20](#20))
([88a3d84](88a3d84))
* update CODEOWNERS to new style/group
([27246ca](27246ca))
* update extraEnv to envFrom
([#58](#58))
([57df25a](57df25a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request May 10, 2024
Merged
This was referenced Jul 23, 2024
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corang corang corang left review comments

@mjnagel mjnagel mjnagel left review comments

@zachariahmiller zachariahmiller zachariahmiller left review comments

@Racer159 Racer159 Racer159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BMP image does not properly load
5 participants
@Michael-Kruggel @corang @Racer159 @mjnagel @zachariahmiller