Make setting of resource limits conditional

deadlycoconuts · Jan 17, 2024 · 8c71d73 · 8c71d73
1 parent 068818a
commit 8c71d73
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/api/turing/cluster/models.go b/api/turing/cluster/models.go
@@ -72,9 +72,12 @@ func (cfg *BaseService) buildResourceReqs(
 	}
 
 	// Set resource limits to request * userContainerCPULimitRequestFactor or UserContainerMemoryLimitRequestFactor
-	limits := map[corev1.ResourceName]resource.Quantity{
-		corev1.ResourceCPU:    ComputeResource(cfg.CPURequests, UserContainerCPULimitRequestFactor),
-		corev1.ResourceMemory: ComputeResource(cfg.MemoryRequests, UserContainerMemoryLimitRequestFactor),
+	limits := map[corev1.ResourceName]resource.Quantity{}
+	if UserContainerCPULimitRequestFactor != 0 {
+		limits[corev1.ResourceCPU] = ComputeResource(cfg.CPURequests, UserContainerCPULimitRequestFactor)
+	}
+	if UserContainerMemoryLimitRequestFactor != 0 {
+		limits[corev1.ResourceMemory] = ComputeResource(cfg.MemoryRequests, UserContainerMemoryLimitRequestFactor)
 	}
 
 	return corev1.ResourceRequirements{
@@ -140,6 +143,9 @@ type ConfigMap struct {
 // Ref:
 // https://github.com/knative/serving/blob/release-0.14/pkg/reconciler/revision/resources/queue.go#L115
 func ComputeResource(resourceQuantity resource.Quantity, fraction float64) resource.Quantity {
+	if fraction == 0 {
+		return resource.Quantity{}
+	}
 	scaledValue := resourceQuantity.Value()
 	scaledMilliValue := int64(math.MaxInt64 - 1)
 	if scaledValue < (math.MaxInt64 / 1000) {