Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket.dart file is missing a factory #553

Closed
DartBot opened this issue Nov 22, 2011 · 10 comments
Closed

WebSocket.dart file is missing a factory #553

DartBot opened this issue Nov 22, 2011 · 10 comments
Assignees
@jacob314

Comments

@DartBot
Copy link

DartBot commented Nov 22, 2011

This issue was originally filed by matthias.wesse...@kaazing.com

What steps will reproduce the problem?

  1. can't instantiate an object from the WebSocket class - A factory/constructor is missing that take the location (e.g. "ws://echo.websocket.org")

What is the expected output? What do you see instead?
Expected => Being able to create a WebSocket object
seeing => can't create such an object due to a lacking factory

What version of the product are you using? On what operating system?
Tried it in the dart lang editor (Alpha). After not being able to create a WebSocket object,
I looked at the source code of the WebSocket.dart file:

http://code.google.com/p/dart/source/browse/trunk/dart/client/html/src/WebSocket.dart

==> lack of factory
@DartBot
Copy link
Author

DartBot commented Nov 22, 2011

This comment was originally written by drfibonacci@google.com

Added Area-UI, Triaged labels.

@dgrove
Copy link
Contributor

dgrove commented Nov 22, 2011

Set owner to @vsmenon.

@vsmenon
Copy link
Member

vsmenon commented Dec 12, 2011

This is fixed for DartC and Frog. Pavel, can you investigate for Dartium? There is a failing test in expectations.

Set owner to podiv...@google.com.

@DartBot
Copy link
Author

DartBot commented Dec 22, 2011

This comment was originally written by jordo...@gmail.com

I believe this only got fixed for dart:dom, because I'm still unable to construct a WebSocket using dart:html.

@justinfagnani
Copy link
Contributor

It looks like not only is there no constructor that I can see for dart:html WebSocket, trying to create a dart:dom WebSocket throws a NotImplement exception in Dartium.

@DartBot
Copy link
Author

DartBot commented Feb 24, 2012

This comment was originally written by podivilov@google.com

Added Fixed label.

@justinfagnani
Copy link
Contributor

Where is this fixed? I don't see any factory or constructor for WebSocket in bleeding_edge and the latest editor build (4589) doesn't have a constructor.

@DartBot
Copy link
Author

DartBot commented Feb 25, 2012

This comment was originally written by @financecoding

It seems the fix was only for dart:dom. Can we get this for dart:html? Also trying to use WebSocket from dart:dom produced "Uncaught Error: INVALID_STATE_ERR: DOM Exception 11" on both Dartium and Chrome. I tried passing the --disable-web-security to both with the same error resulting. I'm on MacOSX if that makes a difference? My command for opening was "open Chromium.app --args --disable-web-security" .

@DartBot
Copy link
Author

DartBot commented Mar 5, 2012

This comment was originally written by podivilov@google.com

I believe it works now in Dartium. Jacob, could you please fix dart:html?

Set owner to @jacob314.
Added Triaged label.

@jacob314
Copy link
Member

Added Fixed label.

nex3 pushed a commit that referenced this issue Aug 31, 2016
@vsmenon
Support module root
4b6e3fe 
Fixes #553

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1960523002 .
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue May 20, 2022
@devoncarew
Bump protobuf to b149f801cf7a5e959cf1dbf72d61068ac275f24b
2b4939a 
Changes:
```
> git log --format="%C(auto) %h %s" c1eb6cb..b149f80
 https://dart.googlesource.com/protobuf.git/+/b149f80 Remove the top level analysis_options.yaml file (#656)
 https://dart.googlesource.com/protobuf.git/+/8f6f307 Fix comment syntax
 https://dart.googlesource.com/protobuf.git/+/665f7b0 Remove trailing whitespace in protobuf/LICENSE
 https://dart.googlesource.com/protobuf.git/+/9ffbaf2 Fix default list type for frozen messages (#654)
 https://dart.googlesource.com/protobuf.git/+/a68bb5a Fix Fixed32 to be parsed as unsigned when parsing proto3 protos (#655)
 https://dart.googlesource.com/protobuf.git/+/6957c98 Convert the field started with underscore and digit to a legal name (#651)
 https://dart.googlesource.com/protobuf.git/+/71defca Account for double.infinity and double.nan in json serializers (#652)
 https://dart.googlesource.com/protobuf.git/+/5a48349 Allow `Timestamp.toDateTime()` to return a `DateTime` in local timezone (#653)
 https://dart.googlesource.com/protobuf.git/+/117e869 Make the toString of enums be the value if names are omitted (#649)
 https://dart.googlesource.com/protobuf.git/+/88c4016 Align the hashCode of a message with an empty unknown field-set with that of no unknown field set (#648)
 https://dart.googlesource.com/protobuf.git/+/eed09c4 Fix proto3 repeated field encoding without packed option (#635)
 https://dart.googlesource.com/protobuf.git/+/8f587b1 Simplify `_FieldSet` getters (#646)
 https://dart.googlesource.com/protobuf.git/+/494f189 Fix compile-protos.sh interpreter (#645)
 https://dart.googlesource.com/protobuf.git/+/5e1a422 Fix typo in protobuf-0.9.0+1 changelog
 https://dart.googlesource.com/protobuf.git/+/46df68a Add `UseResult` annotation to `rebuild` (#631)
 https://dart.googlesource.com/protobuf.git/+/ff5304f Migrate protoc_plugin to null safety (#642)
 https://dart.googlesource.com/protobuf.git/+/657197d Fix typo in GeneratedMessage.copyWith documentation (#641)
 https://dart.googlesource.com/protobuf.git/+/e30a522 Fix sharing coded buffer bytes when parsing `bytes` fields (#640)
 https://dart.googlesource.com/protobuf.git/+/810b166 Clear unknown field when setting an extension field with the same tag (#639)
 https://dart.googlesource.com/protobuf.git/+/d30623b Treat empty and uninitialized Maps the same in equality checks (#638)
 https://dart.googlesource.com/protobuf.git/+/4fe3ee4 Make `MapFieldInfo` key and value types non-nullable (#600)
 https://dart.googlesource.com/protobuf.git/+/c26ac34 Add grpc example to protoc_plugin README (#514)
 https://dart.googlesource.com/protobuf.git/+/c35d787 Revert changes to reserved names to maintain backwards compat (#636)
 https://dart.googlesource.com/protobuf.git/+/146b186 Remove unused `GeneratedMessage` constructors (#634)
 https://dart.googlesource.com/protobuf.git/+/1b12ac9 Remove a closure in `_FieldSet.hashCode` (#633)
 https://dart.googlesource.com/protobuf.git/+/5731242 Minor fix in query_bench set_nested_value benchmark: (#630)
 https://dart.googlesource.com/protobuf.git/+/767ce81 Remove fold() closures from `FieldSet._hashCode`. (#554)
 https://dart.googlesource.com/protobuf.git/+/99bc541 protoc_plugin README fixes and tweaks: (#617)
 https://dart.googlesource.com/protobuf.git/+/e282e17 protobuf benchs: invoke protoc once with all protos (#623)
 https://dart.googlesource.com/protobuf.git/+/bef672b protobuf benchs: fix old --trust-type-annotations flag (#622)
 https://dart.googlesource.com/protobuf.git/+/d072e5f dependabot: check for updates monthly (#620)
 https://dart.googlesource.com/protobuf.git/+/96bdf38 Fix TypeRegistry passing when unpacking nested Any messages from JSON (#568)
 https://dart.googlesource.com/protobuf.git/+/4ec722a Correctly combine hash codes for repeated enums. (#556)
 https://dart.googlesource.com/protobuf.git/+/b96dc21 Testing: don't return static methods in findMemberNames (#618)
 https://dart.googlesource.com/protobuf.git/+/09e8a8d Update protobuf/benchmarks README for #553
 https://dart.googlesource.com/protobuf.git/+/3ef4539 Add a benchmark for computing hashCodes. (#553)
 https://dart.googlesource.com/protobuf.git/+/d232e6e Tweak READMEs: (#610)
 https://dart.googlesource.com/protobuf.git/+/0f01fa9 Update protobuf pubspec.yaml (#616)
 https://dart.googlesource.com/protobuf.git/+/a10426b Update protoc_plugin pubspec.yaml (#615)
 https://dart.googlesource.com/protobuf.git/+/a0021c7 Make `protoName` unCamelCase lazy (#606)
 https://dart.googlesource.com/protobuf.git/+/ded1ac7 Document map key and value fields (#603)
 https://dart.googlesource.com/protobuf.git/+/8792f2a Remove redundant check in PbMap equality check (#604)
 https://dart.googlesource.com/protobuf.git/+/b7f9569 Tweak BuilderInfo and FieldInfo docs: (#597)
 https://dart.googlesource.com/protobuf.git/+/6f85c32 Remove a redundant cast (#598)
 https://dart.googlesource.com/protobuf.git/+/3df8669 Latest mono_repo (#601)
 https://dart.googlesource.com/protobuf.git/+/9da84ae Fix a potential issue in CodedBufferWriter (#594)
 https://dart.googlesource.com/protobuf.git/+/6be405f Remove old and unused test file (#589)
 https://dart.googlesource.com/protobuf.git/+/900cef5 Fix protoc_plugin run-tests make rule (#586)
 https://dart.googlesource.com/protobuf.git/+/2546269 Fix rounding when handling negative timestamps (#580)
 https://dart.googlesource.com/protobuf.git/+/8afce8d Fix Readme `pub get` instead of `pub install`. (#486)
 https://dart.googlesource.com/protobuf.git/+/782fd24 Avoid runtime function type check in lazily created singleton creator functions (#574)
 https://dart.googlesource.com/protobuf.git/+/a7e75cb Update README.md
 https://dart.googlesource.com/protobuf.git/+/23136dc Version bump (#563)
 https://dart.googlesource.com/protobuf.git/+/18346f5 Convert null keys and values to default when parsing map entries (#536)
 https://dart.googlesource.com/protobuf.git/+/bb4cf0b Bump to latest mono_repo - use latest actions (#561)
 https://dart.googlesource.com/protobuf.git/+/835ab75 Remove unneeded imports
 https://dart.googlesource.com/protobuf.git/+/ef733ac latest mono_repo
 https://dart.googlesource.com/protobuf.git/+/ecfb862 Fix test for latest analysis (#543)
 https://dart.googlesource.com/protobuf.git/+/26a0a26 fix insecure link in protoc_plugin readme
 https://dart.googlesource.com/protobuf.git/+/444e855 Bump dart-lang/setup-dart from 1.1 to 1.2 (#535)
 https://dart.googlesource.com/protobuf.git/+/d3e0e4a Fix analysis options
 https://dart.googlesource.com/protobuf.git/+/cf29280 Fix comment references

```

Diff: https://dart.googlesource.com/protobuf.git/+/c1eb6cb51af39ccbaa1a8e19349546586a5c8e31~..b149f801cf7a5e959cf1dbf72d61068ac275f24b/

Tested: relying on existing SDK and protobuf tests
Change-Id: I7f89b998a0aba13999d180ee9814a26a5f1d054d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245228
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 28, 2023
@devoncarew
[deps] rev http, markdown, mockito, tools
97168c5 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

http (https://github.com/dart-lang/http/compare/631d4ec..cad7d60):
  cad7d60  2023-08-26  Alex James  Add response status code test (#1009)
  5ac7cfe  2023-08-24  Alex James  JavaClient stream response body using byte arrays (#1007)
  0e6e58a  2023-08-23  Brian Quinlan  Don't check the formatting of `ffigen`ed code (#1010)

markdown (https://github.com/dart-lang/markdown/compare/faabb1a..56e75df):
  56e75df  2023-08-26  Parker Lougheed  Standardize CommonMark spec links to https and v0.30 (#553)

mockito (https://github.com/dart-lang/mockito/compare/70aabfc..f5abf11):
  f5abf11  2023-08-28  Nate Bosch  Add a best practice sentence about data models

tools (https://github.com/dart-lang/tools/compare/e5ce42a..b72fae8):
  b72fae8  2023-08-24  Danny Tuppeny  Export Survey in package:unified_analytics (#151)

Change-Id: Id09f2300d3132a101dfaf84d9dc475ba92590aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacob314 jacob314

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@justinfagnani @jacob314 @dgrove @vsmenon @DartBot