Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct a regression for a package with a specified set of included libraries #3825

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Correct a regression for a package with a specified set of included libraries #3825

merged 2 commits into from
Aug 2, 2024

Commits on Aug 1, 2024

  1. Correct a regression for a package with a specified set of included l… 

    …ibraries

In 12d271a we change what libraries can count
as a 'canonical library', such that when a set of libraries is specified with
the 'include' option, any library not in the 'include' list is not canonical.
This breaks a few things.

The fix is to add all libraries to the `_allLibraries` field, not taking the
'include' list into consideration. Then when we decide what libraries are
considered to be part of a package, we filter down to 'included' libraries.
    @srawlins
    srawlins committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a5374c9 View commit details
    Browse the repository at this point in the history

  2. windows

    @srawlins
    srawlins committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b99c9c9 View commit details
    Browse the repository at this point in the history