Correct a regression for a package with a specified set of included libraries #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibraries In 12d271a we change what libraries can count as a 'canonical library', such that when a set of libraries is specified with the 'include' option, any library not in the 'include' list is not canonical. This breaks a few things. The fix is to add all libraries to the `_allLibraries` field, not taking the 'include' list into consideration. Then when we decide what libraries are considered to be part of a package, we filter down to 'included' libraries.
|
@srawlins – since Danny mentioned the latest beta – will this need to be cherry picked? |
|
I don't think so. I suspect |
|
CC @dart-lang/analyzer-team ready for review |
bwilkerson
approved these changes
Aug 2, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 5, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/5230f8f..ce09815): ce098154 2024-08-02 Sam Rawlins Bump to 8.0.13 (dart-lang/dartdoc#3827) f24562a6 2024-08-02 Sam Rawlins Correct a regression for a package with a specified set of included libraries (dart-lang/dartdoc#3825) 1e6d5513 2024-08-01 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/dartdoc#3824) ecosystem (https://github.com/dart-lang/ecosystem/compare/2635536..f977423): f977423 2024-08-01 dependabot[bot] Bump the github-actions group with 4 updates (dart-lang/ecosystem#283) webdriver (https://github.com/google/webdriver.dart/compare/718e4c3..b181c9e): b181c9e 2024-08-02 dependabot[bot] Bump dart-lang/setup-dart from 1.6.4 to 1.6.5 (google/webdriver.dart#302) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/32fffa5..119b877): 119b877 2024-08-02 Kevin Moore blast_repo fixes (google/webkit_inspection_protocol.dart#127) Change-Id: I059f0df5aaca7d64829972d9c7bb8f40bfd1e1fc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378576 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 12d271a we change what libraries can count as a 'canonical library', such that when a set of libraries is specified with the 'include' option, any library not in the 'include' list is not canonical. This breaks a few things.
The fix is to add all libraries to the
_allLibrariesfield, not taking the 'include' list into consideration. Then when we decide what libraries are considered to be part of a package, we filter down to 'included' libraries.Fixes #3823 and fixes #3826
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.