Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level to information in pubsub examples #942

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

yash-nisar
Copy link
Contributor

Fixes #936

Signed-off-by: Yash Nisar yashnisar@microsoft.com

Description

Currently, we do support logging but the log level is debug in pubsub examples. Since the default log level in appsettings.json is information, logging is suppressed. We need to enable logging by replacing logger.LogDebug(...) by logger.LogInformation(...)

Issue reference

#936

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Fixes dapr#936

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
@yash-nisar yash-nisar requested review from a team as code owners August 31, 2022 02:37
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #942 (befaf3d) into master (f874d60) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #942   +/-   ##
=======================================
  Coverage   69.51%   69.51%           
=======================================
  Files         155      155           
  Lines        5134     5134           
  Branches      554      554           
=======================================
  Hits         3569     3569           
  Misses       1434     1434           
  Partials      131      131           
Flag Coverage Δ
net5 69.45% <ø> (ø)
net6 69.41% <ø> (ø)
netcoreapp3.1 69.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@halspang halspang merged commit efacff4 into dapr:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change log level to information in pubsub examples
2 participants