Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log level to information in pubsub examples #936

Closed
yash-nisar opened this issue Aug 25, 2022 · 0 comments · Fixed by #942
Closed

Change log level to information in pubsub examples #936

yash-nisar opened this issue Aug 25, 2022 · 0 comments · Fixed by #942
Assignees
@yash-nisar
Labels
kind/bug Something isn't working kind/enhancement New feature or request
Milestone
v1.9

Comments

@yash-nisar
Copy link
Contributor

Expected Behavior

Currently, we do support logging but the log level is debug in pubsub examples. Since the default log level in appsettings.json is information, logging is suppressed. We need to enable logging by replacing logger.LogDebug(...) by logger.LogInformation(...).

Actual Behavior

Logging should not be suppressed as it would hide useful information for understanding the flow.

Steps to Reproduce the Problem

Just run the example as given in the readme.
@yash-nisar yash-nisar added the kind/bug Something isn't working label Aug 25, 2022
@halspang halspang added this to the v1.9 milestone Aug 25, 2022
@halspang halspang added the kind/enhancement New feature or request label Aug 29, 2022
yash-nisar added a commit to yash-nisar/dotnet-sdk that referenced this issue Aug 31, 2022
@yash-nisar
Change log level to information in pubsub examples
4783532 
Fixes dapr#936

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
@yash-nisar yash-nisar mentioned this issue Aug 31, 2022
Merged
3 tasks
halspang added a commit that referenced this issue Sep 1, 2022
@yash-nisar @halspang
Change log level to information in pubsub examples (#942)
efacff4 
Fixes #936

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: halspang <70976921+halspang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-nisar yash-nisar

Labels
kind/bug Something isn't working kind/enhancement New feature or request
Projects
None yet
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

Change log level to information in pubsub examples yash-nisar/dotnet-sdk
2 participants
@yash-nisar @halspang