Adds support for providing Actor type name during runtime.

[bjorkstromm]

Description

Adds support for providing Actor type name during runtime.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #677

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[codecov]

Codecov Report

Merging #680 (cc6c236) into master (5a84326) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   63.58%   63.61%   +0.02%     
==========================================
  Files         129      129              
  Lines        4248     4254       +6     
  Branches      476      477       +1     
==========================================
+ Hits         2701     2706       +5     
  Misses       1419     1419              
- Partials      128      129       +1     

Flag	Coverage Δ
net5	63.49% <85.71%> (+0.02%)	⬆️
netcoreapp3.1	63.56% <85.71%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...Dapr.Actors/Runtime/ActorRegistrationCollection.cs	90.90% <80.00%> (-9.10%)	⬇️
src/Dapr.Actors/Runtime/ActorTypeInformation.cs	41.46% <100.00%> (+1.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a84326...cc6c236. Read the comment docs.

[rynowak]

It's going to take me a bit to review this and rationalize the change. I have to check whether there are other places where we call ActorTypeInformation.Get.

[bjorkstromm]

Ok. To clarify, this should be a non-breaking change. I added an overload for ActorTypeInformation.Get which takes an string parameter for specifying the actor type name.

public static ActorTypeInformation Get(Type actorType)

The above still exists, but will call the below with actorTypeName: null.

public static ActorTypeInformation Get(Type actorType, string actorTypeName)

And then in the above method I've just modified it to check is actorTypeName is provided.

[rynowak]

Ok. To clarify, this should be a non-breaking change. I added an overload for ActorTypeInformation.Get which takes an string parameter for specifying the actor type name.

What I'm concerned about isn't the addition of a new method it's a the introduction of a 'split brain' problem. We need to make sure it's not possible for two parts of the system to disagree about the type name.

[rynowak]

Can you please do the following:

• On ActorTypeInformation - mark TryGet(Type) and Get(Type) as [Obsolete]- we want to make sure we don't have code calling those since they don't accept a type name override.
• On ActorHost we need another overload of CreateForTest that accepts a type name.
• Update the remaining references to Get(Type) to call GetType(Type, null) - these will be unit tests

[bjorkstromm]

Fixed this here bjorkstromm@e1b62c9

But since this PR was unintentionally closed, changes won't appear here. Could you please reopen, or should I open a new PR?

[bjorkstromm]

@rynowak it seems like this was not closed by intention... Can you reopen, and I'll address feedback mentioned here: #680 (comment)