Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added newly added flags for multi app run #3461

Merged
merged 7 commits into from
May 31, 2023

Conversation

pravinpushkar
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

issues
#3460
#3424

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar requested review from a team as code owners May 26, 2023 11:56
@msfussell
Copy link
Member

@pravinpushkar - These changes are good for the template. However can you also update the overview document here https://docs.dapr.io/developing-applications/local-development/multi-app-dapr-run/multi-app-overview/#logs to describe the new settings, notably the ability (now by default) to write to console out. Currently it only talks about writing to file. Thx

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar
Copy link
Contributor Author

@pravinpushkar - These changes are good for the template. However can you also update the overview document here https://docs.dapr.io/developing-applications/local-development/multi-app-dapr-run/multi-app-overview/#logs to describe the new settings, notably the ability (now by default) to write to console out. Currently it only talks about writing to file. Thx

Done

@msfussell msfussell added this to the 1.11 milestone May 30, 2023
…multi-app-dapr-run/multi-app-overview.md

Signed-off-by: Mark Fussell <markfussell@gmail.com>
…multi-app-dapr-run/multi-app-overview.md

Signed-off-by: Mark Fussell <markfussell@gmail.com>
…multi-app-dapr-run/multi-app-overview.md

Signed-off-by: Mark Fussell <markfussell@gmail.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 939fd01 into dapr:v1.11 May 31, 2023
@hhunter-ms hhunter-ms mentioned this pull request Jun 7, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants