-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shivam-51: Add log file paths to dapr list 1228 #1296
shivam-51: Add log file paths to dapr list 1228 #1296
Conversation
@shivam-51 |
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
- Coverage 26.87% 26.83% -0.05%
==========================================
Files 39 39
Lines 3873 3879 +6
==========================================
Hits 1041 1041
- Misses 2758 2764 +6
Partials 74 74
|
Multi app run template introduces |
@pravinpushkar Can you share some documentation for this property? I am not able to understand it's significance. |
PLease see this PR dapr/docs#3461 |
@pravinpushkar @mukundansundar What do you think? |
@shivam-51 @pravinpushkar @mukundansundar My vote would be that, if the log is written to a file, then add/populate the |
+1 to update log paths only when written to only files. In other cases the logs will anyway be available to the console and tolling can use that. @philliphoff However one question - if there are multiple apps writing logs to console then how will the tooling distinguish which log written by which app ? |
@pravinpushkar If the application output is only going to the console, then it'd be unavailable to tooling anyway (unless it was the one to have started the Dapr process and captured the |
a1c485d
to
912672d
Compare
@mukundansundar I have identified the tests need to go into |
Could you explain what errors that you are seeing? |
That's okay. I ran the tests on my fork using github actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivam-51 Almost there, thanks for adding the negative scenarios. Can you add the positive test case as part of the run file scenarios where the list is actually populated with the file path? Inside this function here https://github.com/dapr/cli/blob/master/tests/e2e/standalone/stop_with_run_template_test.go#L121
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
f764579
to
f6c967d
Compare
@mukundansundar can you have a look please? |
Description
Add paths of app and dapr logs to
dapr list
command.Issue reference
Please reference the issue this PR will close: #1228
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: