fix: re-enable CYPRESS_INTERNAL_VITE_DEV development #25364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems fine to me, I think there were issues with cached files but it was awhile ago, maybe not an issue with more recent vite versions |
tgriesser
approved these changes
Jan 5, 2023
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
lmiller1990
approved these changes
Jan 18, 2023
tgriesser
added a commit
that referenced
this pull request
Jan 18, 2023
* develop: (45 commits) fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364) fix: add skip domain injection description (#25463) fix: revert CSP header and script-src addition (#25445) chore: Update v8 snapshot cache (#25401) feat: Do not strip CSP headers from HTTPResponse (#24760) fix: keep spaces in formatted output in test runner (#24687) fix: Restrict dependency versions to known supported ranges (#25380) chore: Update v8 snapshot cache (#25370) feat: experimental skip domain injection (#25307) chore: support vite v4 for component testing (#25365) feat: Use JSX/TSX in generated spec filenames (#25318) docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359) chore: remove lint-changed from scripts/docs (#25308) chore: bump to 12.3.0 [skip ci] (#25355) fix: make NODE_ENV "production" for prod builds of launchpad (#25320) fix: .contains() should only return one element at all times (#25250) feat: add currentRetry to Cypress API (#25297) chore: release @cypress/webpack-dev-server-v3.2.2 chore: release create-cypress-tests-v2.0.1 fix: change wording for spec creation (#25271) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
CYPRESS_INTERNAL_VITE_DEV=1 yarn devwas not working due to Vite updates changing the stdout and causing our process spawner to not proceed with the gulp process. I also addedstripAnsito the matcher as the Vite stdout is colorful.I also removed the
rimraf ./node_modules/.viteas that is where the vite optimized deps live. @tgriesser do you remember why we had to do this? Maybe CI will tell me after I break everything...Steps to test
Run
CYPRESS_INTERNAL_VITE_DEV=1 yarn dev. I had to run this, try and navigate to the app and then restart the process. Vite was optimizing deps but there was too many and it was timing out. It got closer and closer each time and then eventually started working. I'm on a slow machine though so maybe it was just a me thing.How has the user experience changed?
Faster dev environment when making changes to the app/launchpad. Updates went from 20s to less than 1 second.
PR Tasks
cypress-documentation?type definitions?